BF: Sending experiment to Runner was sometimes (wrongly) toggling pilot/run mode#6945
Merged
peircej merged 1 commit intopsychopy:releasefrom Oct 29, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release #6945 +/- ##
===========================================
- Coverage 50.55% 50.55% -0.01%
===========================================
Files 332 332
Lines 61217 61225 +8
===========================================
Hits 30951 30951
- Misses 30266 30274 +8
|
Contributor
|
Works beautifully. Thanks @TEParsons ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution is to split up the code to update the buttons from the code to trigger the event, set modified, etc. so that selecting a new experiment on add can just update the buttons, not alter the experiment file or raise an event.
@mh105 could you pull down and try this out to confirm it fixes the bug you described?