Skip to content

BF: Sending experiment to Runner was sometimes (wrongly) toggling pilot/run mode#6945

Merged
peircej merged 1 commit intopsychopy:releasefrom
TEParsons:release-bf-runner-toggle
Oct 29, 2024
Merged

BF: Sending experiment to Runner was sometimes (wrongly) toggling pilot/run mode#6945
peircej merged 1 commit intopsychopy:releasefrom
TEParsons:release-bf-runner-toggle

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

Solution is to split up the code to update the buttons from the code to trigger the event, set modified, etc. so that selecting a new experiment on add can just update the buttons, not alter the experiment file or raise an event.

@mh105 could you pull down and try this out to confirm it fixes the bug you described?

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.55%. Comparing base (8c041c4) to head (8a7ec21).
Report is 7 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #6945      +/-   ##
===========================================
- Coverage    50.55%   50.55%   -0.01%     
===========================================
  Files          332      332              
  Lines        61217    61225       +8     
===========================================
  Hits         30951    30951              
- Misses       30266    30274       +8     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@mh105
Copy link
Copy Markdown
Contributor

mh105 commented Oct 29, 2024

Works beautifully. Thanks @TEParsons !

@peircej peircej merged commit e001e24 into psychopy:release Oct 29, 2024
@TEParsons TEParsons deleted the release-bf-runner-toggle branch November 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants