Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Memory leak in moviestim2 #838

Merged
merged 1 commit into from Feb 24, 2015
Merged

BF: Memory leak in moviestim2 #838

merged 1 commit into from Feb 24, 2015

Conversation

@isolver
Copy link
Contributor

@isolver isolver commented Feb 18, 2015

  • OpenCV Video player is created once for life of MovieStim2 instance,
    instead of being recreated for each movie load.
  • removed [:] from line:
    ..., self._numpy_frame = self._video_stream.retrieve()
  • removed setFPS(), movie always should play at fps indicated in video
    file
+ OpenCV Video player is created once for life of MovieStim2 instance,
instead of being recreated for each movie load.
+ removed [:] from line:
..., self._numpy_frame = self._video_stream.retrieve()

+ removed setFPS(), movie always should play at fps indicated in video
file
@coveralls
Copy link

@coveralls coveralls commented Feb 18, 2015

Coverage Status

Coverage increased (+0.03%) to 50.88% when pulling bbf7eda on isolver:master into 4f75216 on psychopy:master.

peircej added a commit that referenced this pull request Feb 24, 2015
BF: Memory leak in moviestim2
@peircej peircej merged commit 8b97cd1 into psychopy:master Feb 24, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants