New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: ioHub Linux Mouse events & Closing windows in core.quit() #894

Merged
merged 8 commits into from May 1, 2015

Conversation

Projects
None yet
3 participants
@isolver
Contributor

isolver commented Apr 28, 2015

  • fixes bug in ioHub Linux Mouse events not being reported
  • core.quit() now calls close on any open windows so that it does not need to be done from _del_ call, which often fails to complete fully.

isolver added some commits Jan 14, 2015

BF: Linux Mouse event dispatching
Fixed issue with Linux Mouse events received by iohub not being sent to
iohub server HookManager, and were therefore not generating iohub Mouse
events for the psychopy process.
ENH: iohub Linux Mouse code cleanup
- replaced mixed tabs / spaces to spaces
- removed redundant check for mouse device setting
'report_system_wide_events'
@peircej

This comment has been minimized.

Member

peircej commented Apr 30, 2015

Sol, this one seems to be failing
https://travis-ci.org/psychopy/psychopy/builds/60404409
with the error

      self.winHandle.dispatch_events()

psychopy/visual/window.py:583:


    while xlib.XCheckWindowEvent(_x_display, _window,
                               0x1ffffff, byref(e)):

E ArgumentError: argument 2: <type 'exceptions.TypeError'>: wrong type

It's weird because flip must have been called in other tests but failed on this one (test_bitsShaders). I don't understand it. Any ideas at your end?

@isolver

This comment has been minimized.

Contributor

isolver commented Apr 30, 2015

I have no idea why a call to self.winHandle.dispatch_events() from within
the psychopy window class would suddenly be failing for this test because
of the PR I made. The pull request does have a change in core.py so that
windows are closed when core.quit() is called:

isolver@50e0391

I can't see how that could be causing this exception, but I could try
reverting it so that the change to core.py is removed. Should I give that a
shot?

BTW, when I run the test on windows it runs passed the .flip() ok and only
fails at one of the assert points that checks the array adat, which I guess
is because I do not have the needed hardware?

On Thu, Apr 30, 2015 at 10:49 AM, Jon Peirce notifications@github.com
wrote:

Sol, this one seems to be failing
https://travis-ci.org/psychopy/psychopy/builds/60404409
with the error

  self.winHandle.dispatch_events()

psychopy/visual/window.py:583:

while xlib.XCheckWindowEvent(_x_display, _window,
                           0x1ffffff, byref(e)):

E ArgumentError: argument 2: : wrong type

It's weird because flip must have been called in other tests but failed on
this one (test_bitsShaders). I don't understand it. Any ideas at your end?


Reply to this email directly or view it on GitHub
#894 (comment).

@coveralls

This comment has been minimized.

coveralls commented Apr 30, 2015

Coverage Status

Coverage decreased (-0.0%) to 50.55% when pulling cb22810 on isolver:master into 8772ef0 on psychopy:master.

@isolver

This comment has been minimized.

Contributor

isolver commented Apr 30, 2015

K, now I'm really confused. Why is a test failing for me that I have made 0 related lines of code changes to, but passing for others? Help! ;)

@isolver

This comment has been minimized.

Contributor

isolver commented Apr 30, 2015

Also, why is 'continuous-integration/travis-ci/pr ' passing now OK, but the pull is failing because of 'coverage/coveralls - Coverage decreased (-0.0%) to 50.55%'.

Does this mean it is actually passing now?

peircej added a commit that referenced this pull request May 1, 2015

Merge pull request #894 from isolver/master
BF: ioHub Linux Mouse events & Closing windows in core.quit()

@peircej peircej merged commit 34020c3 into psychopy:master May 1, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.0%) to 50.55%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peircej

This comment has been minimized.

Member

peircej commented May 1, 2015

not sure! I'm merging the commit and we'll see what happens next! it could be that not all the slaves of the testing system are identical?

OK, I just did that and it looks fine. No idea what the issue was but it's gone away with no further effort! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment