Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to set mouse exclusivity for a window in Pyglet #898

Merged

Conversation

Projects
None yet
3 participants
@suddhasourav
Copy link
Contributor

commented May 6, 2015

This function binds the mouse to a window (and makes the cursor invisible). The use-case would be a multi-monitor setting where the participants need to click to respond. Without using a function like this, the cursor can be moved out of the region of the experiment.

@coveralls

This comment has been minimized.

Copy link

commented May 6, 2015

Coverage Status

Coverage decreased (-0.01%) to 50.54% when pulling f0f6bb9 on suddhasourav:ENH_BF_setMouseExclusivityPyglet into 34020c3 on psychopy:master.

@suddhasourav

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2015

I wonder why coveralls is throwing an error here... should I add a test function?

@coveralls

This comment has been minimized.

Copy link

commented May 6, 2015

Coverage Status

Coverage decreased (-0.01%) to 50.54% when pulling f0f6bb9 on suddhasourav:ENH_BF_setMouseExclusivityPyglet into 34020c3 on psychopy:master.

@coveralls

This comment has been minimized.

Copy link

commented May 6, 2015

Coverage Status

Coverage decreased (-0.01%) to 50.54% when pulling f0f6bb9 on suddhasourav:ENH_BF_setMouseExclusivityPyglet into 34020c3 on psychopy:master.

@peircej

This comment has been minimized.

Copy link
Member

commented May 6, 2015

We do get some non-deterministic fails on occasion, but this looks fine. Very minor thing: I wonder if the name might be just:
mouse.setExclusive(True)
rather than:
mouse.setMouseExclusivity(True)
?

@peircej

This comment has been minimized.

Copy link
Member

commented May 6, 2015

(if you push a change and submit a pull request this one will be updated - no need to close and reopen it)

@suddhasourav

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2015

I agree - it's already a method of Mouse. Changed accordingly!

@coveralls

This comment has been minimized.

Copy link

commented May 6, 2015

Coverage Status

Coverage decreased (-0.01%) to 50.53% when pulling a134f48 on suddhasourav:ENH_BF_setMouseExclusivityPyglet into 34020c3 on psychopy:master.

peircej added a commit that referenced this pull request May 6, 2015

Merge pull request #898 from suddhasourav/ENH_BF_setMouseExclusivityP…
…yglet

Function to set mouse exclusivity for a window in Pyglet

@peircej peircej merged commit 1d27a81 into psychopy:master May 6, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.01%) to 50.53%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.