New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fix closed stdout after ExperimentHandler save #902

Merged
merged 2 commits into from May 15, 2015

Conversation

Projects
None yet
3 participants
@philippwiesemann
Contributor

philippwiesemann commented May 14, 2015

If ExperimentHandler's saveAsWideText() function was called with the file name "stdout" (to write to sys.stdout instead of a real file), the standard output was closed afterwards. This was fixed by only closing the used file object if it is not the standard output object.

Also replaced a print statement with call to logging function for consistency.

philippwiesemann added some commits May 14, 2015

BF: Fix closed stdout after ExperimentHandler save
If ExperimentHandler's saveAsWideText() function was called with the
file name "stdout" (to write to sys.stdout instead of a real file), the
standard output was closed afterwards. This was fixed by only closing
the used file object if it is not the standard output object.
@coveralls

This comment has been minimized.

coveralls commented May 14, 2015

Coverage Status

Coverage increased (+0.01%) to 50.53% when pulling 43e3ded on philippwiesemann:fix-data-closed-stdout into c19b868 on psychopy:master.

peircej added a commit that referenced this pull request May 15, 2015

Merge pull request #902 from philippwiesemann/fix-data-closed-stdout
BF: Fix closed stdout after ExperimentHandler save

@peircej peircej merged commit b96a707 into psychopy:master May 15, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 50.53%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment