Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Stop abbreviating condition file path as displayed in loop dialog #913

Merged
merged 1 commit into from Jun 3, 2015

Conversation

@m-macaskill
Copy link
Contributor

@m-macaskill m-macaskill commented Jun 3, 2015

Addresses this issue:
#909

i.e. Builder loop dialogs should now show the full (absolute or relative) path to a conditions file, rather than displaying an abbreviated version (which was created to ensure the filename would always be visible). i.e. now when a path is long, one might have to move the insertion point through the field to see the filename, but the text representation of the path will match the actual path.

@coveralls
Copy link

@coveralls coveralls commented Jun 3, 2015

Coverage Status

Coverage increased (+0.0%) to 50.53% when pulling 26b107e on m-macaskill:master into dca2fda on psychopy:master.

@m-macaskill
Copy link
Contributor Author

@m-macaskill m-macaskill commented Jun 3, 2015

The getAbbrev() function (about line 4856 of builder.py) could probably also be deleted: I just left it there in case it was called elsewhere, but suspect that it isn't.

@@ -4846,8 +4844,11 @@ def toggleVisible(self, evt=None):
else:
self.Show()
def getAbbrev(longStr, n=30):

This comment has been minimized.

@m-macaskill

m-macaskill Jun 3, 2015
Author Contributor

Probably should have deleted this function as well.

peircej added a commit that referenced this pull request Jun 3, 2015
ENH: Stop abbreviating condition file path as displayed in loop dialog
@peircej peircej merged commit 680fddd into psychopy:master Jun 3, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0%) to 50.53%
Details
hoechenberger added a commit to hoechenberger/psychopy that referenced this pull request Nov 21, 2015
We stopped abbreviation condition file paths with psychopy#913. `builder.getApprev()` is
an orphan function since then and not used anymore. I verified that this code is
not called in any other part of PsychoPy anymore, and removed it.
hoechenberger added a commit to hoechenberger/psychopy that referenced this pull request Nov 21, 2015
We stopped abbreviating condition file paths with psychopy#913. `builder.getApprev()` is
an orphan function since then and not used anymore. I verified that this code is
not called in any other part of PsychoPy anymore, and removed it.
hoechenberger added a commit to hoechenberger/psychopy that referenced this pull request Nov 25, 2015
We stopped abbreviating condition file paths with psychopy#913. `builder.getApprev()` is
an orphan function since then and not used anymore. I verified that this code is
not called in any other part of PsychoPy anymore, and removed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants