Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: MovieStim2 had circular reference preventing garbage collection #919

Merged
merged 1 commit into from Jun 11, 2015

Conversation

@peircej
Copy link
Member

@peircej peircej commented Jun 11, 2015

No description provided.

peircej added a commit that referenced this pull request Jun 11, 2015
BF: MovieStim2 had circular reference preventing garbage collection
@peircej peircej merged commit d4f5d02 into psychopy:master Jun 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 50.31%
Details
@peircej

This comment has been minimized.

Copy link
Member Author

@peircej peircej commented on a060d51 Jun 11, 2015

@isolver I think this commit fixes the memory leak that people have been finding with MovieStim2

The issue was that there was a circular reference with the vlc audio stream (moviestim stores a reference to it and it stores a reference to MovieStim's EOS callbacks). I now pass a separate function as a callback and a weakref to the original MovieStim2 instance that the callback can then use to signal the EOS

This comment has been minimized.

Copy link
Contributor

@isolver isolver replied Jul 6, 2015

Cool. Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants