New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fix locking out of Builder Experiment Settings #937

Merged
merged 1 commit into from Jul 12, 2015

Conversation

Projects
None yet
2 participants
@philippwiesemann
Contributor

philippwiesemann commented Jul 8, 2015

If the "Screen" setting in the "Experiment Settings" dialog was set to an unsupported text value, the dialog could not be opened again after closing it. Values which could not be converted to integers raised a ValueError in int() and values which could be converted but were smaller 1 raised a ValueError in wx.Display(). Both cases were fixed by adding additional checks and using the default value (first screen) if needed.

The change also fixed not updating the "Window size" field if the window setting was toggled while an unsupported "Screen" value was set above.

BF: Fix locking out of Builder Experiment Settings
If the "Screen" setting in the "Experiment Settings" dialog was set to
an unsupported text value, the dialog could not be opened again after
closing it. Values which could not be converted to integers raised a
ValueError in int() and values which could be converted but were smaller
1 raised a ValueError in wx.Display(). Both cases were fixed by adding
additional checks and using the default value (first screen) if needed.

The change also fixed not updating the "Window size" field if the window
setting was toggled while an unsupported "Screen" value was set above.

peircej added a commit that referenced this pull request Jul 12, 2015

Merge pull request #937 from philippwiesemann/fix-builder-settings-lo…
…ckout

BF: Fix locking out of Builder Experiment Settings

@peircej peircej merged commit f67dd5b into psychopy:master Jul 12, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.0%) to 50.34%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment