Closing the window should not quit limechat #104

Open
gagarine opened this Issue Apr 19, 2012 · 15 comments

Comments

Projects
None yet

now when we click on the x button on the window (close), limechat fire a dialog asking if we want to quit: "Quit LimeChat? [cancel] [quit]".

On OSX it should just close a window (hide) and not quit the program. Check for example iTunes behavior.

Regards

-1 I hate the OS X window manager. Closing windows leaves processes open. Quitting windows doesn't.

resker commented Sep 26, 2012

The appropriate behavior is prescribed here:

https://developer.apple.com/library/mac/documentation/userexperience/Conceptual/AppleHIGuidelines/Windows/Windows.html#//apple_ref/doc/uid/20000961-TPXREF56

"Users can close windows by choosing Close from the File menu, pressing Command-W, or clicking the close button. Follow the guidelines in this section to ensure that your app closes windows as users expect.

Use modern APIs to preserve the window’s state. Regardless of whether you support Resume, you should remember a window’s onscreen size and position so that you can restore the user’s state when they reopen the window (or reopen your app). To learn more about how to use modern APIs to do this, see “User Interface Preservation” in Mac App Programming Guide.

In general, quit when users close the last open window in your app. In apps that are not document-based, users generally expect the app to quit when they close the main window. If an app continues to perform some function when the main window is closed, it might be appropriate to leave it running after the user closes the main window. For example, iTunes continues to play after the user closes the main window. If users close the last remaining document window in a document-based app and switch to another app, it’s appropriate to quit the app.

Display a close confirmation save dialog when users close a document window that contains unsaved data. Note that this behavior is automatic in document-based apps that adopt Auto Save. The close confirmation save dialog is similar to the standard Save dialog, but it adds a message that asks the user if they want to save their work. The reason for the message is that the action of closing the window implies that the user wants to discard their changes; if this is not the case, the user can respond by saving the data or canceling the close. Note that the close confirmation save dialog is not displayed if the document window closes as the result of some other action, such as the user quitting the app. In these other situations, you should automatically save the user’s work so that the user can choose to save or discard it at a later time."

Owner

psychs commented Sep 26, 2012

According to the HIG, the app should quit when the last window is closed. LimeChat is not a document based app.

If an app continues to perform some function when the main window is closed, it might be appropriate to leave it running after the user closes the main window.

I'd say that Limechat qualifies as doing that.

+1 I'd love to see this change, user experience guidelines aside, it's what every other IRC client for mac does and its what most users have come to expect from them. I like limechat, but the fact that I have to have that window up all the time drives me crazy.

@rolandwalker rolandwalker added a commit to rolandwalker/limechat that referenced this issue Jan 17, 2014

@rolandwalker rolandwalker optionally hide main window instead of closing
closes #104
4c5ff37

+1

@ghost

ghost commented Feb 9, 2014

+1 here too

An unsupported build of v2.39 with this functionality has been posted in my personal repo at https://github.com/rolandwalker/limechat/releases/download/2.39/LimeChat.app.zip .

This is really truly unsupported (did I mention unsupported?). Discussion should stay within the author's repo, either here or at #199.

Thanks, @rolandwalker. @psychs would be great to merge the PR into next LC version

@ghost

ghost commented Feb 10, 2014

@rolandwalker I agree also. but its good to keep it within the official programs source so that @psychs can take a look :)

@xuisce yes, of course, the code is there for review at #199.

@rolandwalker rolandwalker added a commit to rolandwalker/limechat that referenced this issue May 5, 2014

@rolandwalker rolandwalker optionally hide main window instead of closing
closes #104
a73db1d

Unsupported build with this functionality rebased on LimeChat version 2.40 at https://github.com/rolandwalker/limechat/releases/download/2.40-hide-window/LimeChat.app.zip

@rolandwalker rolandwalker added a commit to rolandwalker/limechat that referenced this issue May 6, 2014

@rolandwalker rolandwalker optionally hide main window instead of closing
closes #104
cd7e234

@rolandwalker rolandwalker added a commit to rolandwalker/limechat that referenced this issue Jun 23, 2014

@rolandwalker rolandwalker optionally hide main window instead of closing
closes #104
f3d491d

+1
LimeChat should not behave different from Apple's Messages

I have been keeping the the unsupported build in sync with LimeChat releases at https://github.com/rolandwalker/limechat/releases .

@escowles escowles added a commit to escowles/limechat that referenced this issue Oct 17, 2015

@rolandwalker @escowles rolandwalker + escowles optionally hide main window instead of closing
closes #104
cf129ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment