Skip to content

Add support for PyPy#686

Merged
dvarrazzo merged 2 commits intopsycopg:masterfrom
ngnpope:pypy
Dec 2, 2023
Merged

Add support for PyPy#686
dvarrazzo merged 2 commits intopsycopg:masterfrom
ngnpope:pypy

Conversation

@ngnpope
Copy link
Contributor

@ngnpope ngnpope commented Nov 28, 2023

Supersedes #62.

This seemed to be enough to get everything passing on PyPy 3.10.

@dvarrazzo
Copy link
Member

If we add support for pypy, do we need to add trove classifiers to the metadata? To the pool too?

@dvarrazzo
Copy link
Member

We would also need to add an entry to the supported systems docs and to docs/news.rst

@ngnpope
Copy link
Contributor Author

ngnpope commented Nov 28, 2023

I've pushed up two fixup commits, the first with all the general bits and the second is focused on the gc stuff.

@ngnpope ngnpope force-pushed the pypy branch 2 times, most recently from c9da389 to 74dd5ff Compare November 28, 2023 20:16
@dvarrazzo
Copy link
Member

Hello,

this is largely good! I have squashed the second commit into the first, did some minor cleanup, and also rebased on the 3.1 maintenance branch. If everything is good I will release psycopg 3.1.14 in a few hours, with pypy support.

Thank you very much!

@dvarrazzo dvarrazzo merged commit b4068cd into psycopg:master Dec 2, 2023
@dvarrazzo
Copy link
Member

There was a surprising error in psycopg 3.1 on pypy 3.9, which didn't appear in psycopg master nor on pypy 3.10. I think that the problem is just an anyio 3 bug (master uses anyio 4) so I've skipped the failing tests.

Psycopg 3.1.14 is on the way!

@ngnpope ngnpope deleted the pypy branch December 2, 2023 08:24
@ngnpope
Copy link
Contributor Author

ngnpope commented Dec 2, 2023

Thanks Daniele!

@dvarrazzo
Copy link
Member

Thank you, @ngnpope!

Package released! Thank you for the help, and of course testing is welcome!

@om26er
Copy link

om26er commented Feb 5, 2024

Did we get around to doing any performance benchmarks? Would be great to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants