fix: fix handling of floating point values for connect_timeout#796
Merged
fix: fix handling of floating point values for connect_timeout#796
Conversation
e3b770e to
f8975d4
Compare
Member
Author
|
To be clearer, this can be considered a regression, because in previous implementations of psycopg a float was accepted ok. I found the problem because a program of mine failed to start after a libraries upgrade. |
dlax
approved these changes
Apr 19, 2024
f8975d4 to
34f9cba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
connect_timeoutparameter is specified as integer.It seems that certain libpq versions handle correctly a floating point connect timeout:
others don't
Psycopg doesn't, but mostly by accident, and in the recent version where the connection timeout and the multiple attempts are taken more care of:
it seems safe to parse a floating point error too.