Fix count of chars to escape in textual copy dump #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvarrazzo
force-pushed
the
fix-copy-escape-too-much
branch
from
25cf1f2 to
f0a1926
Compare
We missed to reset the number of chars to escape at every field. As a consequence, we end up resizing and scanning all the fields after the first one requiring an escape and allocating a bit more memory than needed.
dvarrazzo
force-pushed
the
fix-copy-escape-too-much
branch
from
f0a1926 to
31b11f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed to reset the number of chars to escape at every field. As a consequence, we end up resizing and scanning all the fields after the first one requiring an escape and allocating a bit more memory than needed.