Conversation
Drop fallback version in build_libpq.sh script. It was useful to save some typing in development but now it is confusing to have two versions.
Member
Author
|
I would release this changeset in 3.1.20, unless anyone thinks it's a bad idea. I understand OpenSSL 1.1.1 won't receive further updates so going 3.x for some version of x seems advisable. |
dlax
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty long jump, previously used version was 1.1.1, which is now unsupported.
In the past, bundling openssl 0.9.8 was causing random segfaults when the python-bundled openssl was used too (e.g. requesting an https url via urllib). See psycopg/psycopg2#543. A lot of time has passed, and hopefully the case shouldn't present again. Unfortunately it's not easy to test (I was never able to reproduce the bug above).