Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

round() function build failure on Solaris 11 #146

Closed
psycoteam opened this issue Jan 20, 2013 · 3 comments
Closed

round() function build failure on Solaris 11 #146

psycoteam opened this issue Jan 20, 2013 · 3 comments

Comments

@psycoteam
Copy link

@psycoteam psycoteam commented Jan 20, 2013

Originally submitted by: Derek Gulbranson

Attempting to build on Solaris 11 returns the following error:

./psycopg/config.h:146:15: error: static declaration of 'round' follows non-static declaration

Commenting out the declaration of the round function at line 146 in psycopg/config.h allowed the build to complete successfully.

@@@ python

os.uname()
('SunOS', 'domain.name.com', '5.11', 'xxxxx_20121108T343253Z', 'i86pc')

Happy to provide any other information that would be helpful, just let me know.

rel-2.4.6
os-solaris
@dvarrazzo

This comment has been minimized.

Copy link
Member

@dvarrazzo dvarrazzo commented Jan 21, 2013

Please take a look at ticket #97: somebody was trying to clean up this problem and doesn't look like he succeeded. We haven't heard back from him.

Please provide a patch to change the #if guard around the round() definition (while at it, please rewrap it < 80 columns) to make it useful for the solaris versions is worth to support (from 5.9, according to wikipedia).

@dvarrazzo

This comment has been minimized.

Copy link
Member

@dvarrazzo dvarrazzo commented Jan 21, 2013

Googling around, looks like we should define round() for solaris < 10: see https://jira.toolserver.org/browse/TS-1072.

Can you provide such a patch? Thank you.

@dvarrazzo

This comment has been minimized.

Copy link
Member

@dvarrazzo dvarrazzo commented Apr 21, 2013

Patch committed to avoid defining round() for solaris 10 and following

dvarrazzo@d159dfe

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.