build error CentOS 7 PG_INT64_TYPE

[b-harper]

I am attempting to build psycopg2 2.7 for Python 3.6 on CentOS 7 and are getting the following error:

...
gcc -pthread -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -fPIC -DPSYCOPG_DEFAULT_PYDATETIME=1 -DPSYCOPG_VERSION="2.7 (dt dec pq3 ext)" -DPG_VERSION_NUM=90218 -I/usr/include/python3.6m -I. -I/usr/include -I/usr/include/pgsql/server -c psycopg/psycopgmodule.c -o build/temp.linux-x86_64-3.6/psycopg/psycopgmodule.o -Wdeclaration-after-statement
In file included from ./psycopg/replication_cursor.h:30:0,
                 from psycopg/psycopgmodule.c:32:
./psycopg/libpq_support.h:31:32: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'XLogRecPtr'
 typedef unsigned PG_INT64_TYPE XLogRecPtr;
                                ^
In file included from psycopg/psycopgmodule.c:32:0:
./psycopg/replication_cursor.h:47:5: error: unknown type name 'XLogRecPtr'
     XLogRecPtr  write_lsn;        /* LSNs for replication feedback messages */
...

Note, CentOS 7 uses Postgresql 9.2.18. From what I can tell, PG_INT64_TYPE was introduced in Postgresql 9.3. Is Postgresql 9.2.X supported? Any recommendations on a patch file to work around this?

[dvarrazzo]

I would have said PG 9.1 should have worked as well. It doesn't seem the case. Taking a look...

[dvarrazzo]

uint64_t should work as well. Am I right, @a1exsh ?

[b-harper]

Hey @dvarrazzo,

Thanks for the timely update. Adding your libpq_support.h patch, I was able able to build RPMs. Do you think a 2.7.1 release will be coming soon, or should I proceed with building 2.7 with the patch?

[dvarrazzo]

There are a few bugs already open and fixed with 2.7: a 2.7.1 may come out in a few days/one week.

[b-harper]

@dvarrazzo,

Thanks for the additional information. I think we will just wait for 2.7.1.

[dvarrazzo]

Hey @b-harper sorry to bother you, I was wondering if you can give me some RPM advice in bug #518. I've mentioned you there but I'm not sure you get a notification as you haven't participated to that issue. Thank you very much!

[b-harper]

I got email notification about being mentioned on #518 and will reply.

[a1exsh]

@dvarrazzo I'm late to the party, but the fix looks fine. There are uses of int64_t already in the same file anyway.