New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection.dsn shows password for uri format dsn #528

Closed
yamagoya opened this Issue Mar 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@yamagoya
Copy link

yamagoya commented Mar 14, 2017

The connection.dsn string occludes the password when connection is made with a dsn but not when a connection is made with a URI:

>>> dbconn=connect ('dbname=dev user=yama password=secret')
>>> dbconn.dsn
'dbname=dev user=yama password=xxxxxx'
>>> dbconn=connect ('postgres://yama:secret@localhost/dev')
>>> dbconn.dsn
'postgres://yama:secret@localhost/dev'

Shouldn't it also be occluded in the URI case?

@dvarrazzo dvarrazzo added this to the 2.7.2 milestone Mar 15, 2017

@dvarrazzo

This comment has been minimized.

Copy link
Member

dvarrazzo commented Mar 15, 2017

I guess so

dvarrazzo added a commit that referenced this issue Mar 15, 2017

Added tests to verify the password is obscured
The url test fails: see issue #528

@dvarrazzo dvarrazzo closed this in 9f160fd Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment