New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for MSVC 2015 (Python 3.5) #350

Merged
merged 2 commits into from Sep 23, 2015

Conversation

Projects
None yet
4 participants
@Photonios
Contributor

Photonios commented Sep 22, 2015

Recently, Python 3.5 was released, which also changed the default compiler used on Windows to MSVC 2015. Psycopg2 did not yet compile under this version of MSVC.

The fixes are simple:

  • isnan is a macro that MSVC did not define in older version, the code just assumed it wasn't present in all versions, fixed so that it only re-defines it when it is really not existent
  • round is a function that MSVC did previously not define, now they do, fixed by checking for a specific version

I've never contributed to this project, so please let me know if you want to see things differently :)

fogzot added a commit that referenced this pull request Sep 23, 2015

Merge pull request #350 from Photonios/master
Fixes for MSVC 2015 (Python 3.5)

@fogzot fogzot merged commit 4e92322 into psycopg:master Sep 23, 2015

@fogzot

This comment has been minimized.

Show comment
Hide comment
@fogzot

fogzot Sep 23, 2015

Member

Seems fine to me. Thank you for the contribution.

Member

fogzot commented Sep 23, 2015

Seems fine to me. Thank you for the contribution.

@dvarrazzo

This comment has been minimized.

Show comment
Hide comment
@dvarrazzo

dvarrazzo Sep 30, 2015

Member

It's worth a @jerickso roundtrip...

Member

dvarrazzo commented Sep 30, 2015

It's worth a @jerickso roundtrip...

@jerickso

This comment has been minimized.

Show comment
Hide comment
@jerickso

jerickso Sep 30, 2015

Member

Looks fine by me. Also did a quick merge of the patch with the 2.6 branch w/a windows build to make sure I wasn't missing anything obvious, and it passed the build and tests.

Member

jerickso commented Sep 30, 2015

Looks fine by me. Also did a quick merge of the patch with the 2.6 branch w/a windows build to make sure I wasn't missing anything obvious, and it passed the build and tests.

@dvarrazzo

This comment has been minimized.

Show comment
Hide comment
@dvarrazzo

dvarrazzo Oct 1, 2015

Member

Thank you all, I've merged these patches to the 2.6 maintenance branch too.

Member

dvarrazzo commented Oct 1, 2015

Thank you all, I've merged these patches to the 2.6 maintenance branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment