Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Python 3.5 was released, which also changed the default compiler used on Windows to MSVC 2015. Psycopg2 did not yet compile under this version of MSVC.
The fixes are simple:
isnan
is a macro that MSVC did not define in older version, the code just assumed it wasn't present in all versions, fixed so that it only re-defines it when it is really not existentround
is a function that MSVC did previously not define, now they do, fixed by checking for a specific versionI've never contributed to this project, so please let me know if you want to see things differently :)