New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suport for msys2 enviroment #658

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@welitonfreitas

welitonfreitas commented Jan 2, 2018

this resolve erro on #558

@dvarrazzo

This comment has been minimized.

Member

dvarrazzo commented Jan 2, 2018

If you really want to declare msys2 supported you should add automatic build to appveyor. If you don't I can merge this MR (once the window breakage is fixed) but cannot guarantee it won't break again in future.

@@ -561,7 +561,7 @@ def is_py_64():
if not PLATFORM_IS_WINDOWS:
define_macros.append(('PSYCOPG_VERSION', '"' + PSYCOPG_VERSION_EX + '"'))
else:
define_macros.append(('PSYCOPG_VERSION', '\\"' + PSYCOPG_VERSION_EX + '\\"'))
define_macros.append(('PSYCOPG_VERSION', '\"' + PSYCOPG_VERSION_EX + '\"'))

This comment has been minimized.

@dvarrazzo

@dvarrazzo dvarrazzo closed this Feb 19, 2018

dvarrazzo added a commit that referenced this pull request Feb 19, 2018

Avoid quoting the string in the psycopg version macro
Use a macro trick to add the quotes. This seems more portable than
passing the quotes to the command line (see #658).

https://gcc.gnu.org/onlinedocs/cpp/Stringizing.html

dvarrazzo added a commit that referenced this pull request Feb 19, 2018

Avoid quoting the string in the psycopg version macro
Use a macro trick to add the quotes. This seems more portable than
passing the quotes to the command line (see #658).

https://gcc.gnu.org/onlinedocs/cpp/Stringizing.html

dvarrazzo added a commit that referenced this pull request Feb 19, 2018

Avoid quoting the string in the psycopg version macro
Use a macro trick to add the quotes. This seems more portable than
passing the quotes to the command line (see #658).

https://gcc.gnu.org/onlinedocs/cpp/Stringizing.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment