From 8267e854cfc7016d0c5aac4bc2eff9cdb431624b Mon Sep 17 00:00:00 2001 From: psyomn Date: Mon, 12 Apr 2021 23:47:39 -0400 Subject: [PATCH] [ds] Fix lints --- ds/ll.go | 28 ++++++++++++++-------------- ds/ll_test.go | 7 ++++--- 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/ds/ll.go b/ds/ll.go index a678667..f36e9c0 100644 --- a/ds/ll.go +++ b/ds/ll.go @@ -11,13 +11,13 @@ var ( ErrEmptyList = errors.New("linked list is empty") ) -type node struct { - next *node - item interface{} +type Node struct { + next *Node + Item interface{} } type LinkedList struct { - head *node + head *Node size uint64 } @@ -30,20 +30,20 @@ func (s *LinkedList) Peek() (interface{}, error) { return nil, ErrEmptyList } - return s.head.item, nil + return s.head.Item, nil } func (s *LinkedList) Add(item interface{}) { cursor := s.nextEmpty() if cursor == nil { - s.head = &node{} - s.head.item = item + s.head = &Node{} + s.head.Item = item } else { - cursor.next = &node{} + cursor.next = &Node{} cursor = cursor.next - cursor.item = item + cursor.Item = item } - s.size += 1 + s.size++ } func (s *LinkedList) Delete(item interface{}) error { @@ -55,14 +55,14 @@ func (s *LinkedList) Delete(item interface{}) error { // pray to the garbage collector, ohmmmmm lag.next = node.next - s.size -= 1 + s.size-- return nil } -func (s *LinkedList) Find(item interface{}) (*node, *node, error) { +func (s *LinkedList) Find(item interface{}) (*Node, *Node, error) { lag := s.head for cursor := s.head; cursor != nil; cursor = cursor.next { - if cursor.item == item { + if cursor.Item == item { return cursor, lag, nil } lag = cursor @@ -79,7 +79,7 @@ func (s *LinkedList) Length() uint64 { return s.size } -func (s *LinkedList) nextEmpty() *node { +func (s *LinkedList) nextEmpty() *Node { if s.head == nil { return nil } diff --git a/ds/ll_test.go b/ds/ll_test.go index 1985d8a..88ad507 100644 --- a/ds/ll_test.go +++ b/ds/ll_test.go @@ -49,10 +49,10 @@ func TestLinkedListFind(t *testing.T) { } if node == nil { - t.Errorf("should have node data") + t.Fatalf("%s", "should have node data") } - value := node.item.(int) + value := node.Item.(int) if err != nil { t.Errorf("%s", err.Error()) } @@ -77,9 +77,10 @@ func TestLinkedListFindSmall(t *testing.T) { if node == nil { t.Errorf("should have node data") + return } - value := node.item.(int) + value := node.Item.(int) if err != nil { t.Errorf("%s", err.Error()) }