New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added getEps #39

Merged
merged 5 commits into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@MiGraber
Collaborator

MiGraber commented Mar 25, 2018

No description provided.

@ptl93

This comment has been minimized.

Owner

ptl93 commented Mar 25, 2018

@MiGraber I merged the branch into master. Please modify

par.vals = list(eps = 0.15)
with your function :)

thanks

@lintr-bot

This comment has been minimized.

lintr-bot commented on 5754724 Mar 25, 2018

R/makeClusterTask.R:131:5: style: Place a space before left parenthesis, except in a function call.

if(is.null(par.vals$eps)){
    ^
@lintr-bot

This comment has been minimized.

lintr-bot commented on 0f6a930 Mar 25, 2018

R/makeClusterTask.R:147:5: style: Place a space before left parenthesis, except in a function call.

if(is.null(par.vals$eps)){
    ^
@lintr-bot

This comment has been minimized.

lintr-bot commented Mar 25, 2018

R/makeClusterTask.R:147:5: style: Place a space before left parenthesis, except in a function call.

if(is.null(par.vals$eps)){
    ^
@MiGraber

This comment has been minimized.

Collaborator

MiGraber commented Mar 25, 2018

With eps foxed to 0.15:
#37 (comment)
now:
grafik
grafik
Probably the eps is still not optimal espacially for the comb plot but much better than befor.

MiGraber added some commits Mar 25, 2018

@MiGraber

This comment has been minimized.

Collaborator

MiGraber commented Mar 25, 2018

Ready for merging?

@ptl93

This comment has been minimized.

Owner

ptl93 commented Mar 26, 2018

Yes. Please merge

@MiGraber MiGraber merged commit 263da25 into master Mar 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MiGraber MiGraber deleted the mg_findEps branch Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment