Develop #19
Merged
Develop #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors string building operations to use explicit CRLF line endings and updates GitHub Actions workflow references. The changes focus on standardizing line ending handling in code generation and simplifying workflow naming.
- Replaces
AppendLine()calls withAppend()+ explicit"\r\n"for consistent line endings - Updates GitHub Actions workflow references from
test.ymltotest-task.yml - Improves line ending detection logic in the WriteFile method
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| LanguageTags/Rfc5646DataGen.cs | Adds blank line in data generation |
| LanguageTags/Rfc5646Data.cs | Refactors string building to use explicit CRLF line endings |
| LanguageTags/Iso6393Data.cs | Refactors string building to use explicit CRLF line endings |
| LanguageTags/Iso6392Data.cs | Refactors string building and improves line ending detection logic |
| .github/workflows/test-pr.yml | Updates workflow reference and adds descriptive name |
| .github/workflows/publish-release.yml | Updates workflow reference and adds descriptive name |
| .github/workflows/merge-bot-pr.yml | Updates step names for consistency |
Comments suppressed due to low confidence (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.