From aca3f27a59d357541ab88db00c02b2aabaa4c24d Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 28 Aug 2026 20:04:53 -0700 Subject: [PATCH] Give the closing-reference line its own template field (#1070 follow-up) Copilot's review of the develop -> main promotion PR (#1077) sharpened Qodo's earlier ambiguity finding: the closing-reference sentence sat inside the fenced brief with no field-name prefix, unlike the template's other five fields, so it read as literal content handed to the subagent instead of an instruction to whoever assembles the brief. Gave it a "Close:" field, phrased the same way line 45 already resolves the identical insert-canonical-content-at-assembly-time pattern ("quote X into the prompt"). --- .agents/skills/local-strict-review/SKILL.md | 4 ++-- .claude-plugin/fleet-skills/.source-digest | 2 +- .../fleet-skills/skills/local-strict-review/SKILL.md | 4 ++-- .github/skills/local-strict-review/SKILL.md | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.agents/skills/local-strict-review/SKILL.md b/.agents/skills/local-strict-review/SKILL.md index ba5dfbe6..27f1238e 100644 --- a/.agents/skills/local-strict-review/SKILL.md +++ b/.agents/skills/local-strict-review/SKILL.md @@ -48,8 +48,8 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. -Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation - Discipline", referenced rather than restated here. +Close: quote `AGENTS.md`'s own unresolved-rule closing line ("Context and Delegation + Discipline") into the prompt, do not restate it here. ``` **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. diff --git a/.claude-plugin/fleet-skills/.source-digest b/.claude-plugin/fleet-skills/.source-digest index e1971e55..f470fe62 100644 --- a/.claude-plugin/fleet-skills/.source-digest +++ b/.claude-plugin/fleet-skills/.source-digest @@ -1 +1 @@ -126057363d858c0a +4dbdf71167625f52 diff --git a/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md b/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md index ba5dfbe6..27f1238e 100644 --- a/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md +++ b/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md @@ -48,8 +48,8 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. -Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation - Discipline", referenced rather than restated here. +Close: quote `AGENTS.md`'s own unresolved-rule closing line ("Context and Delegation + Discipline") into the prompt, do not restate it here. ``` **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. diff --git a/.github/skills/local-strict-review/SKILL.md b/.github/skills/local-strict-review/SKILL.md index ba5dfbe6..27f1238e 100644 --- a/.github/skills/local-strict-review/SKILL.md +++ b/.github/skills/local-strict-review/SKILL.md @@ -48,8 +48,8 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. -Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation - Discipline", referenced rather than restated here. +Close: quote `AGENTS.md`'s own unresolved-rule closing line ("Context and Delegation + Discipline") into the prompt, do not restate it here. ``` **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not.