Skip to content

ci: address security findings - #389

Merged
konstin merged 2 commits into
pubgrub-rs:devfrom
woodruffw-forks:ww/ci-cleanup
Nov 11, 2025
Merged

konstin merged 2 commits into
pubgrub-rs:devfrom
woodruffw-forks:ww/ci-cleanup

Conversation

@woodruffw

Copy link
Copy Markdown
Contributor

Hi there! This addresses a handful of low-impact findings from zizmor.

Key changes:

  • Dropped the default permissions on all workflows to {} (i.e. no permissions), and have only added explicit permissions where actually needed (at the moment, just the docs workflow).
  • Disabled actions/checkout's implicit credential persistence everywhere.
  • In a separate commit, I've removed/replaced the various usages of (unpinnable) rust-toolchain action with either the runner's own stable rust toolchain (which is already installed) or an explicit rustup invocation for a nightly toolchain where necessary.

Of these changes, I suspect the rust-toolchain one will merit the most attention 🙂 -- per dtolnay/rust-toolchain#160 there's currently no great way to pin that action in a way that ensures reproducibility/hermetic CI runs, so I've opted to remove it instead. However, I've put that in a separate commit and I'm happy to remove it from the proposed changes here if you consider the unpinned action here an acceptable tradeoff!

Signed-off-by: William Woodruff william@astral.sh

Signed-off-by: William Woodruff <william@astral.sh>
Or, where nightly is required, bootstrap it through rustup directly.

Signed-off-by: William Woodruff <william@astral.sh>
@woodruffw
woodruffw marked this pull request as ready for review November 10, 2025 19:49

@konstin konstin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@konstin
konstin enabled auto-merge November 11, 2025 15:44
@konstin
konstin added this pull request to the merge queue Nov 11, 2025
Merged via the queue into pubgrub-rs:dev with commit 5f713f4 Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants