Repository navigation
ci: address security findings - #389
Merged
Merged
Conversation
Signed-off-by: William Woodruff <william@astral.sh>
Or, where nightly is required, bootstrap it through rustup directly. Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
marked this pull request as ready for review
November 10, 2025 19:49
konstin
enabled auto-merge
November 11, 2025 15:44
konstin
added this pull request to the merge queue
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! This addresses a handful of low-impact findings from zizmor.
Key changes:
{}(i.e. no permissions), and have only added explicit permissions where actually needed (at the moment, just the docs workflow).actions/checkout's implicit credential persistence everywhere.rust-toolchainaction with either the runner's own stable rust toolchain (which is already installed) or an explicitrustupinvocation for a nightly toolchain where necessary.Of these changes, I suspect the
rust-toolchainone will merit the most attention 🙂 -- per dtolnay/rust-toolchain#160 there's currently no great way to pin that action in a way that ensures reproducibility/hermetic CI runs, so I've opted to remove it instead. However, I've put that in a separate commit and I'm happy to remove it from the proposed changes here if you consider the unpinned action here an acceptable tradeoff!Signed-off-by: William Woodruff william@astral.sh