Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions #1193

Merged
merged 1 commit into from Mar 17, 2020
Merged

Conversation

@roelofr
Copy link
Contributor

roelofr commented Mar 17, 2020

Thank you for taking the time to work on a Pull Request for this project!

To ensure your PR is dealt with swiftly please check the following:

  • All changes have been squashed into a single commit

Since I blew up the PR list with all my fixes concerning the covid-19 change, I also noticed that pull-requests don't get validated.

Since I don't know why Travis didn't work, and I do very much know how GitHub actions work, I added a check to GitHub actions that runs on pull requests and after pushing to the repo.

Let me know if this is useful.

@yannbertrand

This comment has been minimized.

Copy link
Collaborator

yannbertrand commented Mar 17, 2020

That's an awesome contribution!

As I don't have access to public-apis settings, I can't add Travis hook validation (which is running on each PR). Hopefully, I don't need any settings change for GitHub Actions to work directly...

Let's try and fix it if needed! If we can make it, we'll need to update the status badge in the readme 😉

@yannbertrand yannbertrand merged commit 4a31955 into public-apis:master Mar 17, 2020
@yannbertrand

This comment has been minimized.

Copy link
Collaborator

yannbertrand commented Mar 17, 2020

See #1194
image

@roelofr

This comment has been minimized.

Copy link
Contributor Author

roelofr commented Mar 17, 2020

Houston, we got errors 🎉

@roelofr roelofr deleted the roelofr:added-github-actions branch Mar 17, 2020
@yannbertrand yannbertrand changed the title Added GitHub Actions Add GitHub Actions Mar 17, 2020
@yannbertrand

This comment has been minimized.

Copy link
Collaborator

yannbertrand commented Mar 17, 2020

That's great!

I'm not that familiar with Actions, could it be possible to only have one triggered build instead of two?

And by any chance, run builds for all the opened PR 😅

mangalakader added a commit to mangalakader/public-apis that referenced this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.