Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private methods in abstract custom mapper should not be considered as custom mapping method #104

Closed
softdays opened this issue Jul 22, 2016 · 0 comments
Closed

Private methods in abstract custom mapper should not be considered as custom mapping method #104

softdays opened this issue Jul 22, 2016 · 0 comments
Labels
enhancement
Milestone
0.15

Comments

@softdays
Copy link

Sometimes we have to factorize of the logic of conversion within private methods. Selma displays a warning on private methods used in abstract mapper:
Custom mapping method should be *public* (Fix modifiers of the method) on convert
In this case it seems that the warning is not relevant.
slemesle added a commit that referenced this issue Jul 29, 2016
@slemesle
#104 - Remove compiler warning for method not considered as custom ma…
52ea679 
…pper

Fix junit.framework deprecation
slemesle added a commit that referenced this issue Jul 29, 2016
@slemesle
#104 - Add #104 to release note
789ac91
@slemesle slemesle added this to the 0.15 milestone Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
2 participants
@slemesle @softdays