Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out `_d2` function #262

Closed
sashadev-sky opened this issue May 15, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@sashadev-sky
Copy link
Collaborator

commented May 15, 2019

First Time?

This is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

The problem

We rewrite the same function, _d2 in a few of our files for each new "handle" class to have. Instead, we can define this function on L.EditHandle, the common class the other handle classes extend, and it will be available to all of them.

Solution

Where to find the relevant lines of code:

Delete the _d2 function from the following files:

/* Distance between two points in cartesian space, squared (distance formula). */
_d2: function(a, b) {
var dx = a.x - b.x,
dy = a.y - b.y;
return Math.pow(dx, 2) + Math.pow(dy, 2);
}

/* Distance between two points in cartesian space, squared (distance formula). */
_d2: function(a, b) {
var dx = a.x - b.x,
dy = a.y - b.y;
return Math.pow(dx, 2) + Math.pow(dy, 2);
}

/* Distance between two points in cartesian space, squared (distance formula). */
_d2: function(a, b) {
var dx = a.x - b.x,
dy = a.y - b.y;
return Math.pow(dx, 2) + Math.pow(dy, 2);
}

  1. Then, copy it into src/edit/EditHandle.js (you can add it as the last function defined on the L.EditHandle class).

Thanks!!

Step by Step

  • Claim this issue with a comment here, below, and ask any clarifying questions you need
  • Fork the repository and set it up locally following the main repo README instructions https://github.com/publiclab/Leaflet.DistortableImage
  • Create a new feature branch with a unique name descriptive to the issue
  • Try to fix the issue following the steps above, but even before you're done, you can:
    commit your changes to your branch and start a pull request (see contributing to Public Lab software) but mark it as "in progress" if you have questions or if you haven't finished
  • Reference this issue in your pull request body
  • Once you submit your pull request, if there's an additional checklist provided for getting it merged, get those boxes checked off. Either way, mention me @sashadev-sky for a review.

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

💬 Get help

If you need any help - here are some options:

@esraodaci

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

I would like to claim this one

@sashadev-sky

This comment has been minimized.

Copy link
Collaborator Author

commented May 15, 2019

@esraodaci Thank you it is all yours :)

esraodaci added a commit to esraodaci/Leaflet.DistortableImage that referenced this issue May 16, 2019

@esraodaci esraodaci referenced this issue May 16, 2019

Merged

Fixes #262 #266

sashadev-sky added a commit to esraodaci/Leaflet.DistortableImage that referenced this issue May 20, 2019

sashadev-sky added a commit that referenced this issue May 20, 2019

Fixes #262 (#266)
* Fixes #262

* refactor out d2 function update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.