Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor _addToolbar in LDC.E.js #383

rexagod opened this issue Aug 15, 2019 · 4 comments


Copy link

commented Aug 15, 2019

I guess JS was throwing an error for this.toolbar not being initialized for this if that's why we have this in a try block? If that's the case then why not check "in" the object (this) keys for the toolbar property? That should avoid the try catch blocks and keep things simple.

Also, is suppressing the errors here okay? Maybe we could send these to the error logs? Just a thought, what do you think?

_Originally posted by @rexagod in

@rexagod rexagod changed the title Refactor addHooks for LDC.E.js Refactor _addToolbar in LDC.E.js Aug 15, 2019


This comment has been minimized.

Copy link
Collaborator Author

commented Aug 15, 2019

@rexagod rexagod added this to the Version 1.0.0 Release milestone Aug 15, 2019


This comment has been minimized.

Copy link
Collaborator Author

commented Aug 26, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: In this one, we need you to remove the try catch blocks and instead add a check before the try block to see if this object has toolbar property present in its Object,keys output.

    try {
    if (!this.toolbar) {
    this.toolbar = L.distortableImage.controlBar({
    actions: this.editActions,
    position: 'topleft',
    }).addTo(map, group);'toolbar:created');
    } catch (e) { }

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!


This comment has been minimized.

Copy link

commented Aug 30, 2019

may i have a go at this?


This comment has been minimized.

Copy link

commented Sep 3, 2019

@BrooksPatola yes go for it! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.