New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge rotation handles #93

Closed
first-timers bot opened this Issue May 3, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@first-timers

first-timers bot commented May 3, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This will enlarge the "handles" you use to manipulate images -- making it easier to use on a tablet or phone! We'd love your help!

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • πŸ‘Œ Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • πŸ“ Update the file src/edit/RotateHandle.js in the Leaflet.DistortableImage repository (press the little pen Icon) and edit the line as shown below.

@@ -3,7 +3,7 @@ L.RotateHandle = L.EditHandle.extend({
 		TYPE: 'rotate',
 		icon: new L.Icon({ 
 			iconUrl: 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABG0lEQVR4nKXSvS5EURTF8d8V/SBBr9F7A4zGNy9AQytRKIaCgkQhehrzAmZ8hUI8wYxHmJ7CjCcYxT0nublmJlecZueerPXf69y9k0a57D9nqMfdJI7QRBtfaKCC8bw4ySVYww1G+jRsYwsPvRKsohbMT5jHKMawgOfwfYeVPGACVSQ4xDLe0AldX7GI46CpxudEwE7o/IizPvHhBC8hyU4WsBnq5QBzPBdZTwRMhfpeANDMeiIgCbVbABA1SRbQCnWmACBqWllALdS9AoD9rCcCrvAtXaSDAeYKlqTjvc4CPqQb1sU56phFSTreOen2nQbNdvD8WuV16SqX+iTohEb38WI4J6hjGrvYkI6qK/1htyH2Z9aQT/Dn8wMV5jnxJDAcbAAAAABJRU5ErkJggg%3D%3D',
-			iconSize: [16, 16],
+			iconSize: [32, 32],
 			iconAnchor: [8, 8]}
 		)
 	},
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@Nadjedu

This comment has been minimized.

Contributor

Nadjedu commented May 6, 2018

Can I work on this?

@Phanx091

This comment has been minimized.

Contributor

Phanx091 commented May 6, 2018

May i claim this issue?

@jywarren

This comment has been minimized.

Contributor

jywarren commented May 6, 2018

@Nadjedu

This comment has been minimized.

Contributor

Nadjedu commented May 6, 2018

Can you review the pull request?

@jywarren

This comment has been minimized.

Contributor

jywarren commented May 6, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 25, 2018

This is complete, thanks everyone for your help!

@jywarren jywarren closed this Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment