Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume Travis builds and remove karma errors #127

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@rexagod
Copy link
Collaborator

commented Feb 6, 2019

Fixes #122, re: #126

Success logs

▶ grunt build
Running "jshint:source" (jshint) task
>> 11 files lint free.

Running "jshint:grunt" (jshint) task
>> 1 file lint free.

Running "karma:development:start" (karma) task

START:
06 02 2019 16:45:54.868:INFO [karma-server]: Karma v3.1.4 server started at http://0.0.0.0:9876/
06 02 2019 16:45:54.870:INFO [launcher]: Launching browsers PhantomJS with concurrency unlimited
06 02 2019 16:45:54.890:INFO [launcher]: Starting browser PhantomJS
06 02 2019 16:45:58.299:INFO [PhantomJS 2.1.1 (Linux 0.0.0)]: Connected on socket LpERJgPzRtZzNKSWAAAA with id 70904612
  L.DistortableImageOverlay
    #_calculateProjectiveTransform
      ✖ Should (skipped)
    getCenter
      ✔ Should return the center when the outline of the image is a rectangle.
  L.DistortableImage.Edit
    ✔ Should be initialized along with each instance of L.DistortableImageOverlay.
    ✔ Should keep handles on the map in sync with the corners of the image.
    ✖ Should keep image in sync with the map while dragging. (skipped)
  L.RotateHandle
    _calculateRotation
      ✔ Should return 0 when given the same latlng twice.
    _calculateScalingFactor
      ✔ Should return 1 when given the same latlng twice.
  L.DomUtil
    .getMatrixString
      ✔ Should
  L.MatrixUtil
    .multmm
      ✔ Should act as the identity when the identity matrix is on the left.
      ✔ Should act as the identity when the identity matrix is on the right.
    .multsm
      ✔ Should scale the identity matrix.
    .general2DProjection
      ✔ Should return the 3*3 identity matrix when each corner is mapped back to itself.
      ✔ Should return a scalar multiple of the 3*3 identity matrix when the image is scaled.

Finished in 0.159 secs / 0.096 secs @ 16:45:58 GMT+0530 (IST)

SUMMARY:
✔ 11 tests completed
ℹ 2 tests skipped

Running "coverage" task

Running "concat:dist" (concat) task

Done.

/cc @jywarren

rexagod added some commits Feb 6, 2019

@jywarren jywarren merged commit 6080832 into publiclab:master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jywarren

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

Great work!!!! Super -- very exciting! 👍 👍 👍 👍

I changed the description so it doesn't close the planning issue but only the more specific one: Fixes #122, re: #126

@rexagod rexagod referenced this pull request Feb 8, 2019

Closed

Fix JSHint errors #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.