New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for empty bold tags functionality #202

Open
rexagod opened this Issue Jan 3, 2019 · 9 comments

Comments

Projects
None yet
4 participants
@rexagod
Copy link
Collaborator

rexagod commented Jan 3, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

To implement a test for detecting empty bold tags (for #198). This test would help automate builds determine whether the #198 functionality is working fine or not.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • Fork and clone this repository

  • Create a new uniquely named branch and checkout to it

  • Install dependencies using npm install

  • Install grunt cli using npm install -g grunt-cli

Implement the Solution

The corresponding test for this feature can be implemented by adding the following funtion to ./spec/javascripts/rich_text_module_spec.js file.

it("displays alert for empty bold tags",function() {

    var enter = jQuery.Event("keydown", {keyCode:13})

    var temp_el = module.textarea

    module.setMode('markdown');

    module.textarea.innerHTML = '**';

    $(temp_el).trigger(enter)

    module.textarea.innerHTML = '**';

    $(temp_el).trigger(enter)

    expect($('.invalid-bold-tags-warning').length).not.toBeNull();

  })
  • Build using grunt build

  • Test your assertions using grunt jasmine. If all specs pass, follow next steps.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@rexagod

This comment has been minimized.

Copy link
Collaborator

rexagod commented Jan 4, 2019

@publiclab/reviewers Think we can label this as a fto? If not, what changes should I make? Looking forward to opening more fto's and your guidance will be appreciated! Thanks!

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Jan 4, 2019

Hi, @rexagod thanks! Would you mind taking a close look at this guide, which helps formatting of FTOs? This will be very awesome once it's fully formatted! Eager to build this community 👍 🎉 🙌

https://publiclab.org/n/13667

@rexagod

This comment has been minimized.

Copy link
Collaborator

rexagod commented Jan 5, 2019

@jywarren I've edited the issue. Can we now label it as a fto?

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Jan 7, 2019

Hi, @rexagod -- we're almost there! Sorry i took time off over the weekend, just chiming back in now. Actually it can be really effective to add the "preamble" as in this example, with some extra welcoming friendly language: publiclab/plots2#4189

Once we add that, we should be good to go! Thank you and i'm updating the activity guide I'd linked to to emphasize that section as well! (FTOs have evolved over the years 😄 )

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 9, 2019

Hi @rexagod I transformed it to FTO, you can use this template to create new issues. It's in reference to Publiclab editor. Thanks!

@rexagod

This comment has been minimized.

Copy link
Collaborator

rexagod commented Jan 9, 2019

Thanks! I've made the required edits. Will open up a few more very soon.

@IgorWilbert

This comment has been minimized.

Copy link
Contributor

IgorWilbert commented Jan 11, 2019

Hello! I need to practice using Git for cloning and forking, since I made a big mess last time I tried. May I take this issue please?

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 11, 2019

Go ahead @IgorWilbert! Thanks!

@gauravano gauravano added in progress and removed help wanted labels Jan 11, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Jan 11, 2019

Awesome!!!

@IgorWilbert IgorWilbert referenced this issue Jan 12, 2019

Merged

Add test for empty bold tags functionality #220

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment