New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font format in section 3 #251

Open
IgorWilbert opened this Issue Jan 24, 2019 · 14 comments

Comments

Projects
None yet
5 participants
@IgorWilbert
Copy link
Member

IgorWilbert commented Jan 24, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: this will fix #241. All that needs to be done is replace this line

<h4><b>By place name :</b></h4>

With this line <p class="ple-map-content"><b>By place name:</b></p>.
This line

<h4><b>By entering co-ordinates :</b></h4>

With this line <p class="ple-map-content"><b>By entering co-ordinates:</b></p>.

And finally, paste the following line (with the same indentation/format of the rest of the code)

.ple-map-content { font-size: 16px; }

on the file named PublicLab.Editor/dist/PublicLab.Editor.css, just after line number 36.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@NitinMore7

This comment has been minimized.

Copy link

NitinMore7 commented Jan 24, 2019

please, can I work on this

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 24, 2019

Hi @NitinMore7, go ahead and feel free to ask your doubts here. Thanks!

@NitinMore7

This comment has been minimized.

Copy link

NitinMore7 commented Jan 24, 2019

so I need to clone this repo, make the given changes & then commit them and start a pull request ,is that's right?

@rexagod

This comment has been minimized.

Copy link
Collaborator

rexagod commented Jan 24, 2019

@NitinMore7 You'll need to clone your forked repo instead of this one.

@NitinMore7

This comment has been minimized.

Copy link

NitinMore7 commented Jan 24, 2019

Its done can you please check and confirm

@akshaygupta533

This comment has been minimized.

Copy link

akshaygupta533 commented Jan 24, 2019

Can I work on this?

@IgorWilbert

This comment has been minimized.

Copy link
Member Author

IgorWilbert commented Jan 24, 2019

@akshaygupta533 please check other FTO issues, @NitinMore7 already claimed this one, sorry. @NitinMore7 did you remember to open a PR?

@NitinMore7

This comment has been minimized.

Copy link

NitinMore7 commented Jan 24, 2019

@IgorWilbert i just did

@IgorWilbert

This comment has been minimized.

Copy link
Member Author

IgorWilbert commented Jan 24, 2019

Good job @NitinMore7, thanks! Do you know how to squash your commits (turn your commits into a single commit with all the changes)? Would you mind doing it?

@NitinMore7

This comment has been minimized.

Copy link

NitinMore7 commented Jan 24, 2019

@IgorWilbert how do I squash my commits if I've already pushed them

@IgorWilbert

This comment has been minimized.

Copy link
Member Author

IgorWilbert commented Jan 24, 2019

@NitinMore7 you will have to rebase your branch. Run the command $ git rebase -i HEAD~4 and in the text editor that comes up, replace the words "pick" with "squash", except for the one at the top of the list. Then use $ git push origin branch-name --force to push to upstream. Please see this page for reference, and ask for help if something goes wrong. This can be a bit annoying to make.

@NitinMore7

This comment has been minimized.

Copy link

NitinMore7 commented Jan 25, 2019

I've squashed those commits into one can you please check and confirm it

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 27, 2019

Hi @NitinMore7, please paste the link of your PR here or tag this issue in the PR. Thanks!

@NitinMore7

This comment has been minimized.

Copy link

NitinMore7 commented Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment