New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrasting address bar support #259

Open
rexagod opened this Issue Jan 25, 2019 · 12 comments

Comments

Projects
None yet
4 participants
@rexagod
Copy link
Collaborator

rexagod commented Jan 25, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: All we need to do here is add the following line in the <head>, <meta name="theme-color" content="#000">. This would help the mobile chrome viewscreens to adapt to a better contrast theme for the Editor, hence improving readability and user engagement.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 25, 2019

@gauravano We'd love to have you start away on PL.Editor! However, if you want to assign someone else to this issue, feel free to do so. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 25, 2019

Thanks @rexagod!@niravasher you wanna claim this?

@gauravano gauravano removed their assignment Jan 25, 2019

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 25, 2019

@gauravano If I may weigh in here, I think @niravasher already has an ongoing PR at #255, and has been comfortably communicating his ideas on many different issues for a while now. If it's fine by you, I'd recommend assigning this to someone new with zero experience about the PL.Editor environment, so that they can get upto speed in no time, hence helping a potential contributor too. But I also understand if for some reason you would still like to assign this to @niravasher.

Both options and fine by me.

@anto004

This comment has been minimized.

Copy link

anto004 commented Jan 25, 2019

Hi, can I take this one?

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 26, 2019

Hi @anto004, sure go ahead!

Hi @rexagod, actually @niravasher asked me for an first-timer-only so after going through then opened FTO's, I found that @akshaygupta533 also needs one, so asked him. And, thanks for creating FTO at such a short notice. If you see any possible issue which can be a good FTO, please tag @akshaygupta533 there, as he might be interested in solving one.

Thanks!

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 26, 2019

@gauravano Made one at #261.

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 26, 2019

Thanks @rexagod !

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 26, 2019

No problem @gauravano.

@sog01

This comment has been minimized.

Copy link

sog01 commented Jan 28, 2019

Is still opened ?

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Jan 28, 2019

Hi @sog01, PR for this issue is already in progress, so please take a look at other issues at https://code.publiclab.org/#r=all. Thanks!

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 29, 2019

@sog01 There's a fto open here if you're interested. Thanks!

@sog01

This comment has been minimized.

Copy link

sog01 commented Jan 29, 2019

Wow thanks @rexagod, I will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment