New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designing a manifest for PL.Editor #261

Open
rexagod opened this Issue Jan 26, 2019 · 14 comments

Comments

Projects
None yet
4 participants
@rexagod
Copy link
Collaborator

rexagod commented Jan 26, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: In this fto, you will need to design a mainfest.json for a mobile-rich experience of the PL.Editor. Take some time to understand the theme and design of the Editor, and design a mainfest.json file that you think will suit best to the Editor.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 26, 2019

@akshaygupta533 Would you like do work on this one?

@rexagod rexagod referenced this issue Jan 26, 2019

Open

Contrasting address bar support #259

0 of 5 tasks complete
@IgorWilbert

This comment has been minimized.

Copy link
Member

IgorWilbert commented Jan 26, 2019

@rexagod this is an awesome idea, thank you! However, shouldn't we add a bit more detail to make it a FTO? This can be done in many different ways

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 26, 2019

@IgorWilbert I did include a MDN link where anyone can easily understand the procedure of creating a manifest so I didn't feel the need to explicity include it in the description. However, if you'd like to, you can create a new fto with the details and I'll close this one. 👍

@IgorWilbert

This comment has been minimized.

Copy link
Member

IgorWilbert commented Jan 26, 2019

@rexagod sorry, I didn't notice. Yes, with the MDN link creating the manifest seems pretty straightforward. By the way, I updated the code and included an image in #244 , looking forward to hear your thoughts :)

@robert-aron

This comment has been minimized.

Copy link

robert-aron commented Jan 27, 2019

Hey, can I give this a try?

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 27, 2019

Sure, go ahead @robert-aron!

@robert-aron

This comment has been minimized.

Copy link

robert-aron commented Jan 27, 2019

@rexagod Just a question, where is the manifest.json file supposed to go? I put it in /examples/data/ but I'm not sure if that's the right place.

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 27, 2019

I suppose we can place it there and copy the relative path in the index.

@akshaygupta533

This comment has been minimized.

Copy link

akshaygupta533 commented Jan 27, 2019

Sorry got a bit busy @rexagod. Is there anything else I can work on?

@akshaygupta533

This comment has been minimized.

Copy link

akshaygupta533 commented Jan 27, 2019

@robert-aron Can I work on this if you don't mind? I have been looking for an fto issue for a long time now 😁

@robert-aron

This comment has been minimized.

Copy link

robert-aron commented Jan 27, 2019

@akshaygupta533 Oh sure, go ahead. Also I can give you the manifest file I wrote if you want it

@akshaygupta533

This comment has been minimized.

Copy link

akshaygupta533 commented Jan 27, 2019

Yes please. Can you paste the link to it here?

@akshaygupta533

This comment has been minimized.

Copy link

akshaygupta533 commented Jan 27, 2019

On second thoughts, I will try doing it on my own. Thanks anyways 😄

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Jan 27, 2019

Thank you @robert-aron for assigning this to @akshaygupta533. Please go ahead and check-out the ftos here for submitting your first PR!

Thanks!

@akshaygupta533 akshaygupta533 referenced a pull request that will close this issue Jan 27, 2019

Open

manifest: Add manifest for the prototype of PL.Editor #263

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment