New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Image Upload should only import images #274

Open
rexagod opened this Issue Feb 4, 2019 · 10 comments

Comments

Projects
None yet
5 participants
@rexagod
Copy link
Collaborator

rexagod commented Feb 4, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update: You need to add a accept="image/*"attribute to the code segment below so that the main image upload imports nothing other than an image from the user.

    <p><input type="file" name="image[photo]" /></p>

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@arah24

This comment has been minimized.

Copy link

arah24 commented Feb 4, 2019

Hi,

This is my first time contributing to an OSS - how would I claim this issue?

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Feb 4, 2019

Hey @asura1990! You don't need to do anything, just notify us that you want to take up this issue, we'll make sure no one is already assigned to it, and then you may start working on it!

As for now nobody is assigned to this issue, so please go ahead!

@arah24

This comment has been minimized.

Copy link

arah24 commented Feb 4, 2019

Hi @rexagod I've created a new branch and trying to push to it however I get an error stating.

`ERROR: Permission to publiclab/PublicLab.Editor.git denied to asura1990.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
`
This is even after I've enabled SSH key for my github account for the machine I'm using, would I have to do anything specific for the project in order to push to the repo?

@rexagod

This comment has been minimized.

Copy link
Collaborator Author

rexagod commented Feb 4, 2019

That's because you haven't forked this repo. You are currently trying to push directly to this repository which is only allowed to the mods. Please fork a repository, commit to that, and start a PR from there.

@arah24

This comment has been minimized.

Copy link

arah24 commented Feb 4, 2019

Ok thanks!

@arah24

This comment has been minimized.

Copy link

arah24 commented Feb 4, 2019

Hi,

I've created a pull request.
#276

@arah24 arah24 referenced a pull request that will close this issue Feb 4, 2019

Open

Feature 274 import images #276

@amit-07

This comment has been minimized.

Copy link

amit-07 commented Feb 7, 2019

I want to work on this issue as a first timer I want a bit of guidance

@arah24

This comment has been minimized.

Copy link

arah24 commented Feb 7, 2019

I've already created a pull request to resolve this issue and it was merged into master.

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Feb 7, 2019

Hi @amit-07, we would love to have your help, you can find first-timer-issues at https://code.publiclab.org.
In case, you can't find one there too, feel free to comment here, and we will create one for you.
Thanks!

@ShazZaman

This comment has been minimized.

Copy link

ShazZaman commented Feb 10, 2019

Hello Guys, is anybody currently working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment