Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a connect with us section containing the links provided in the footer #174

Open
Rishabh570 opened this Issue Apr 12, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@Rishabh570
Copy link
Collaborator

Rishabh570 commented Apr 12, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file index.html and demo.css in the community-toolbox repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

In index.html

  • On line 144 add these changes,
$DIFF
+ <div class="row" id="connectwithus">
+ <h2 class="text-center d-block">Connect with us</h2>
+ <p>You can connect with us on any of these platforms:</pc>
+ <div class="text-center" id="connectwithusbody">
+ <a class="col-md-2" href="https://www.facebook.com/PublicLab/" title="Facebook" ><i class="fa fa-facebook fa-3x"></i> </a>
+ <a class="col-md-2" href="https://twitter.com/PublicLab?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor" title="Twitter" ><i class="fa fa-twitter fa-3x"></i> </a>
+ <a class="col-md-2" href="https://github.com/publiclab" title="Organization" ><i class="fa fa-github fa-3x"></i> </a>
+ <a class="col-md-2" href="https://publiclab.org" title="Publiclab Website"><i class="fa fa-globe fa-3x"></i></a>
+ </div>
+ </div>
  • From line 155 upto line 161, remove everything,
$DIFF
- <div class="col-md-6 text-center">
- <span class="float-md-right">
- <a href="https://www.facebook.com/PublicLab/" title="Facebook" ><i class="fa fa-facebook"></i> </a>
- <a href="https://twitter.com/PublicLab?ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Eauthor" title="Twitter" ><i class="fa fa-twitter"></i> </a>
- <a href="https://github.com/publiclab" title="Organization" ><i class="fa fa-github"></i> </a>
- <a href="https://publiclab.org" title="Publiclab Website"><i class="fa fa-globe"></i> Publiclab</a> </span>
- </div>

On demo.css

$DIFF
+ #connectwithus {
+ margin: auto auto 5em;
+ }
+ #connectwithusbody {
+ overflow: hidden;
+ }
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@ibrahimm02

This comment has been minimized.

Copy link

ibrahimm02 commented Apr 12, 2019

Hi, can I work on this issue?

@Rishabh570

This comment has been minimized.

Copy link
Collaborator Author

Rishabh570 commented Apr 12, 2019

@ibrahimm02 sure, go ahead! Let me know if you get stuck somewhere 👍

@ibrahimm02

This comment has been minimized.

Copy link

ibrahimm02 commented Apr 12, 2019

@Rishabh570 thanks.

@kingingcole

This comment has been minimized.

Copy link

kingingcole commented Apr 12, 2019

@ibrahimm02 Are you still working on this?

@Varadhu93

This comment has been minimized.

Copy link

Varadhu93 commented Apr 13, 2019

Hi Can I claim this issue?

@Rishabh570

This comment has been minimized.

Copy link
Collaborator Author

Rishabh570 commented Apr 13, 2019

Hi @Varadhu93 @kingingcole, @ibrahimm02 is working on this issue right now...you can help with some other issue. We're happy to have you here 👍
Thanks!!!

ibrahimm02 added a commit to ibrahimm02/community-toolbox that referenced this issue Apr 13, 2019

Update index.html
Added connect with us section. Issue publiclab#174

@ibrahimm02 ibrahimm02 referenced a pull request that will close this issue Apr 14, 2019

Open

Connect with us section #178

1 of 5 tasks complete

ibrahimm02 added a commit to ibrahimm02/community-toolbox that referenced this issue Apr 15, 2019

Update index.html
Fixes publiclab#174.

I also set up fontawesome, to view the icons in the footer.

@ibrahimm02 ibrahimm02 referenced a pull request that will close this issue Apr 15, 2019

Open

Connect with us section #186

5 of 5 tasks complete

ibrahimm02 added a commit to ibrahimm02/community-toolbox that referenced this issue Apr 16, 2019

Update index.html
Issues publiclab#174

Removed font-awesome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.