Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent contributors list's logic and repository fetching precedence #197

Open
Rishabh570 opened this issue May 13, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@Rishabh570
Copy link
Collaborator

commented May 13, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file index.js, community-toolbox.js, getAllContribsUtility.js and getRecentCommitsUtility.js in the community-toolbox repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

CHANGES TO BE DONE

  • /models/index.js
$DIFF
+ require('../../node_modules/urlhash/urlHash');
+ let org = urlHash().getUrlHashParameter('o') || 'publiclab';
+ let getReposUtil = require('../utils/getAllContribsUtility')
- window.addEventListener('DOMContentLoaded', initialize());
+ window.addEventListener('DOMContentLoaded', () => {
+ getReposUtil.getAllRepos(org);
+ initialize();
+ });
  • /scripts/community-toolbox.js, at this line
$DIFF
- model_utils.getItem('repos').then((repos) => {
+ return model_utils.getItem('repos').then((repos) => {
  • /utils/getAllContribsUtility.js
$DIFF
+ let model_utils = require('../models/utils')
  • /utils/getRecentCommitsUtility.js
$DIFF
- model_utils.getItem('repos').then((repos) => {
+ return model_utils.getItem('repos').then((repos) => {
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@usamacjs

This comment has been minimized.

Copy link

commented May 13, 2019

hello, I was searching for a post like this one and it seems very welcoming. I have never contributed to open source and I feel like this will be a start for me. Please guide me through the process and I'll be thankful to you.

@Rishabh570

This comment has been minimized.

Copy link
Collaborator Author

commented May 14, 2019

Hi @usamacjs, it's very good to see you're getting started with open source 😃. You can start by taking a look at this and this...follow the steps shown there to fork and clone the repo, then you can do the required changes and open a Pull Request (PR) regarding that :)

You can always ask for help if you feel stuck at any point in the process.

Thanks and best of luck!!! 🎉

@dannomayer

This comment has been minimized.

Copy link

commented May 18, 2019

Hi @Rishabh570 I see this is still open, up for grabs? I have also never contributed to open source and am excited to start doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.