Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Noise-Reduction Module #1170

Open
Divy123 opened this issue Jul 14, 2019 · 19 comments

Comments

@Divy123
Copy link

commented Jul 14, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

To gain a sense of what the issue targets go to MODULES.md , we need to add documentation for Noise-reduction module. You can go and have a look at the module here to see the types of processing supported.

  • 📝 Update the following file

    1. MODULES.md and add documentation for Noise Reduction Module

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 14, 2019

@aashna27 can help here.

@aashna27

This comment has been minimized.

Copy link

commented Jul 14, 2019

@Divy123 I ll edit the issue description it includes some portion of #1167.

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 14, 2019

Yeah sure!

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 14, 2019

@aashna27 can you please our Gitter chat? I have replied there.

@aashna27

This comment has been minimized.

Copy link

commented Jul 14, 2019

@aashna27 can you please our Gitter chat? I have replied there.

ohhkay yeah, thanks a lot!!

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 14, 2019

😄

@duyquangnguyenhac

This comment has been minimized.

Copy link

commented Jul 15, 2019

I would like to pick up this issue!

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

@aashna27 if you can please update this issue,

@duyquangnguyenhac you can go ahead as soon as the issue is updated.

@aashna27

This comment has been minimized.

Copy link

commented Jul 15, 2019

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 15, 2019

Ohh I didn't notice!!
Thanks a lot @aashna27
@duyquangnguyenhac please go ahead!!

@aashna27

This comment has been minimized.

Copy link

commented Jul 15, 2019

@duyquangnguyenhac

This comment has been minimized.

Copy link

commented Jul 17, 2019

Hello guys!

I just finished cloning the repository. I'm going through the module and trying to understand it. Will need some help later because I'm a beginner :D

@aashna27

This comment has been minimized.

Copy link

commented Jul 20, 2019

Yeah sure! Please let me know what is your concern!
So after cloning the repo you can run it using grunt serve and then you can navigate to find the noise reduction module and what it does! Just pick up an image that has a lot of noise and let it pass through the reduction module!

Also to know what needs to be done in this issue you can go through the description and all the other module's description to get an idea of what it is! Add your own inputs and make a pull request!
Let us know if you have any other doubts! Hope you understand

@duyquangnguyenhac

This comment has been minimized.

Copy link

commented Jul 21, 2019

Hi,
I've finished adding my inputs for the documentation. I'm trying to make a pull request on the file but for some reason it seems like I don't have permission to make a pull request. I'll post the error message below, and perhaps someone could help me clarify the issue.
Thank you, James

Quangs-MacBook-Pro:docs quangnguyen$ git push --set-upstream origin document-noise-reduction-module
remote: Permission to publiclab/image-sequencer.git denied to duyquangnguyenhac.
fatal: unable to access 'https://github.com/publiclab/image-sequencer.git/': The requested URL returned error: 403

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 23, 2019

You are trying to push directly to publiclab/image-sequencer.
Try pushing it to your own fork. It will work then.

@duyquangnguyenhac

This comment has been minimized.

Copy link

commented Jul 25, 2019

OK here it is!
jywarren#14

@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 27, 2019

Actually for this PR, this has to go from your fork that will be the origin in your local:
https://github.com/duyquangnguye/image-sequencer.git

and upstream be:
https://github.com/publiclab/image-sequencer.git

You have made the PR to jywarren's repo, you have to do it to the public lab one.

@duyquangnguyenhac

This comment has been minimized.

Copy link

commented Jul 29, 2019

Okay I fixed it, sorry for the inconvenience.

#1189

@duyquangnguyenhac duyquangnguyenhac referenced a pull request that will close this issue Jul 29, 2019
4 of 4 tasks complete
@Divy123

This comment has been minimized.

Copy link
Author

commented Jul 29, 2019

Thanks a lot @duyquangnguyenhac and its completely fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.