Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Resize Option in Resize Module #1217

Open
aashna27 opened this issue Aug 20, 2019 · 17 comments

Comments

@aashna27
Copy link

commented Aug 20, 2019

Hi, this is a first-timers-only issue,we've worked to make it more legible to folks who either haven't contributed to our code-base before, or for folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before look through our general help wanted issues. Thanks!

🤔 What you will need to know.

Make yourself familiar with the code-base and the resize module.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

Currently the resize module accepts a parameter to resize the image and resizes both the image height and width with that. We need to give the user and option to select which mode the user wants, "Custom Resize" or "Proportional Resize"(the current one).

"Custom resize" would resize the image as per the width and height parameters entered.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are not familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

🤔 Questions?

Leave a comment below!

@aashna27

This comment has been minimized.

Copy link
Author

commented Aug 25, 2019

@BrooksPatola

This comment has been minimized.

Copy link

commented Aug 30, 2019

is this still open?

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

I guess yes. Go ahead

@BrooksPatola

This comment has been minimized.

Copy link

commented Aug 30, 2019

Thanks. I'll give it ago @HarshKhandeparkar

@BrooksPatola

This comment has been minimized.

Copy link

commented Aug 30, 2019

@HarshKhandeparkar If i'm understanding correctly, you wish to keep the current Proportional Resize option (125% start value) but would like to add a Custom Resize option that would take both a width and heigh percentage then apply that to the image?

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

yes exactly

@BrooksPatola

This comment has been minimized.

Copy link

commented Aug 30, 2019

@HarshKhandeparkar Would you have a general outline to go about doing this? Just so I am not missing any steps. If not, I will dive into it soon.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

Nope. You can start right away. I would generally start by understanding the current code and play with it and then fix the issue.

@BrooksPatola

This comment has been minimized.

Copy link

commented Aug 31, 2019

@HarshKhandeparkar

I know I should include custom resize functionality in the resize module itself, but I am having difficulty finding where I should include the html tags for the module. When i run the project with 'npm start', it goes to the example page, then I can use Chrome dev tools to see the current elements, I am just unsure of the file to target to include new values. If you have any suggestions, let me know. Otherwise, I'll continue to play around more with it.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

@Starkyv

This comment has been minimized.

Copy link

commented Sep 11, 2019

Is this issue still open?

@Starkyv

This comment has been minimized.

Copy link

commented Sep 12, 2019

How to Claim the issue?

@Starkyv

This comment has been minimized.

Copy link

commented Sep 12, 2019

@HarshKhandeparkar

I know I should include custom resize functionality in the resize module itself, but I am having difficulty finding where I should include the html tags for the module. When i run the project with 'npm start', it goes to the example page, then I can use Chrome dev tools to see the current elements, I am just unsure of the file to target to include new values. If you have any suggestions, let me know. Otherwise, I'll continue to play around more with it.

@BrooksPatola Do you need any help in solving this issue? I can help you out if so.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

If @BrooksPatola doesn't reply in a few days, I guess you can work on it if you want @Starkyv

@BrooksPatola

This comment has been minimized.

Copy link

commented Sep 12, 2019

@harshithpabbati Still on it. Will update within the next week.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Np. Take your time. Just let us know if you are still on it. BTW, I am HarshKhandeparkar not harshitpabbati 😃 . It is a very common typo

@Starkyv

This comment has been minimized.

Copy link

commented Sep 16, 2019

@harshithpabbati Still on it. Will update within the next week.

Sure @BrooksPatola . Take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.