Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Change UI Previews' Crop Default Options #1477

Closed
HarshKhandeparkar opened this issue Jan 12, 2020 · 2 comments · Fixed by #1487
Closed

Fix/Change UI Previews' Crop Default Options #1477

HarshKhandeparkar opened this issue Jan 12, 2020 · 2 comments · Fixed by #1487

Comments

@HarshKhandeparkar
Copy link
Member

@HarshKhandeparkar HarshKhandeparkar commented Jan 12, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open-source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

What is to be done?

In the UI of ImageSequencer, there are quick buttons for frequently used modules.
Screenshot from 2020-01-13 00-01-51

These buttons have image previews in the background which represent the module. Each of these previews has its own default options set in the UI.

var previewSequencerSteps = {
'resize': '125%',
'brightness': '175',
'saturation': '0.5',
'rotate': 90,
'contrast': 90,
'crop': {
'x': 0,
'y': 0,
'w': '(50%)',
'h': '(50%)',
'noUI': true
}
};

Due to recent changes, the defaults of crop module may lead to an error

'crop': {
'x': 0,
'y': 0,
'w': '(50%)',
'h': '(50%)',
'noUI': true
}

Inputs like (50%) which have braces shall not be used anymore. You will have to change these inputs and any others if any.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Modify the file insertPreview.js

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@ojurkiewicz

This comment has been minimized.

Copy link

@ojurkiewicz ojurkiewicz commented Jan 12, 2020

I'd like to help with that.

@ojurkiewicz ojurkiewicz mentioned this issue Jan 13, 2020
5 of 5 tasks complete
@HarshKhandeparkar

This comment has been minimized.

Copy link
Member Author

@HarshKhandeparkar HarshKhandeparkar commented Jan 14, 2020

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.