Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint bucket module is getting wrong input for fillColor #1488

Closed
blurry-x-face opened this issue Jan 13, 2020 · 8 comments · Fixed by #1519
Closed

Paint bucket module is getting wrong input for fillColor #1488

blurry-x-face opened this issue Jan 13, 2020 · 8 comments · Fixed by #1519

Comments

@blurry-x-face
Copy link
Member

@blurry-x-face blurry-x-face commented Jan 13, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file PaintBucket.js in the $REPO repository (press the little pen Icon) and edit the line as shown below.

-
+27.  fillColor[3] =  fillColor[3] * 256;

See this page for some help in taking your first steps!

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@DevanshCodes

This comment has been minimized.

Copy link

@DevanshCodes DevanshCodes commented Jan 13, 2020

Can I claim it?

@blurry-x-face

This comment has been minimized.

Copy link
Member Author

@blurry-x-face blurry-x-face commented Jan 13, 2020

Sure, Go ahead

@Olusamimaths

This comment has been minimized.

Copy link

@Olusamimaths Olusamimaths commented Jan 15, 2020

Can I claim this?

@blurry-x-face

This comment has been minimized.

Copy link
Member Author

@blurry-x-face blurry-x-face commented Jan 15, 2020

If @DevanshCodes is not working on it you can.

@Olusamimaths

This comment has been minimized.

Copy link

@Olusamimaths Olusamimaths commented Jan 16, 2020

The step by step instruction says

Update the file PaintBucket.js in the $REPO repository (press the little pen Icon) and edit the line as shown below.

But nothing is shown below it.

@blurry-x-face

This comment has been minimized.

Copy link
Member Author

@blurry-x-face blurry-x-face commented Jan 16, 2020

There, done!

@Olusamimaths

This comment has been minimized.

Copy link

@Olusamimaths Olusamimaths commented Jan 17, 2020

Thank you

@Olusamimaths

This comment has been minimized.

Copy link

@Olusamimaths Olusamimaths commented Jan 17, 2020

Fixed. Pull request here:
#1519

Thank you.

Olusamimaths added a commit to Olusamimaths/image-sequencer that referenced this issue Jan 17, 2020
Corrected the multiplier from 256 to 255
@Olusamimaths Olusamimaths mentioned this issue Jan 18, 2020
5 of 5 tasks complete
jywarren added a commit that referenced this issue Jan 21, 2020
* fillColor getting correct color

* Fixed #1488

Corrected the multiplier from 256 to 255

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.