Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colobar default image is not correct. #1538

Open
root00198 opened this issue Jan 18, 2020 · 10 comments
Open

Colobar default image is not correct. #1538

root00198 opened this issue Jan 18, 2020 · 10 comments

Comments

@root00198
Copy link
Member

@root00198 root00198 commented Jan 18, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

You will have to fix a module name colorbar. The issue is that the starting of the colorbar overlay is shifted a bit right. Refer the below GIF.
output

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file src/modules/colorbar/module.js.

See this page for some help in taking your first steps!

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@arghac14

This comment has been minimized.

Copy link
Member

@arghac14 arghac14 commented Jan 19, 2020

@root00198 can I take this one?

@root00198

This comment has been minimized.

Copy link
Member Author

@root00198 root00198 commented Jan 19, 2020

Yeah sure...

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

@HarshKhandeparkar HarshKhandeparkar commented Jan 19, 2020

Sorry, @arghac14 but you cannot claim more than one First Timers Only issue.

@akshaygupta533

This comment has been minimized.

Copy link

@akshaygupta533 akshaygupta533 commented Jan 19, 2020

@HarshKhandeparkar can you assign this to me?

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

@HarshKhandeparkar HarshKhandeparkar commented Jan 19, 2020

Yeah. Go ahead!

akshaygupta533 added a commit to akshaygupta533/image-sequencer that referenced this issue Jan 19, 2020
@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

@HarshKhandeparkar HarshKhandeparkar commented Jan 20, 2020

@root00198 the PR #1542 fixes the module but the test is still failing. We'll have to open a followup to fix this.

@Starkyv

This comment has been minimized.

Copy link

@Starkyv Starkyv commented Jan 22, 2020

Is this issue still open?

@root00198

This comment has been minimized.

Copy link
Member Author

@root00198 root00198 commented Jan 22, 2020

No it is not... Someone already created a pull request...

akshaygupta533 added a commit to akshaygupta533/image-sequencer that referenced this issue Jan 22, 2020
akshaygupta533 added a commit to akshaygupta533/image-sequencer that referenced this issue Jan 22, 2020
@neelesh17

This comment has been minimized.

Copy link

@neelesh17 neelesh17 commented Jan 25, 2020

Is this issue still open?

@blurry-x-face

This comment has been minimized.

Copy link
Member

@blurry-x-face blurry-x-face commented Jan 25, 2020

@neelesh17 This issue already has a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.