New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of message in Add step box #392

Open
vanguard07 opened this Issue Oct 5, 2018 · 14 comments

Comments

Projects
None yet
5 participants
@vanguard07

vanguard07 commented Oct 5, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Problem

Fixing the alignment of message "Select a new module to add to your sequence." in the Add step box on home page.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file index.html and demo.css in the image-sequencer repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below are the steps as to how to approach the solution:

  1. Go to

    <p class="info" style="padding:8px;">Select a new module to add to your sequence.</p>
    and change it to - <p class="info">Select a new module to add to your sequence.</p>

  2. Go to demo.css and add the following lines in the end of the stylesheet:

.info {
padding: 8px;
text-align: center;
}
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@gitmate

This comment has been minimized.

Show comment
Hide comment
@gitmate

gitmate bot Oct 5, 2018

GitMate.io thinks the contributor most likely able to help you is @GitMate[bot].

Possibly related issues are #390 (Fix alignment of image sequencer description), #345 (Display a flash message on removal of a step), #132 (fix CLI --options parameter and add example), and #378 (add a website icon to the website link).

gitmate bot commented Oct 5, 2018

GitMate.io thinks the contributor most likely able to help you is @GitMate[bot].

Possibly related issues are #390 (Fix alignment of image sequencer description), #345 (Display a flash message on removal of a step), #132 (fix CLI --options parameter and add example), and #378 (add a website icon to the website link).

@gitmate

This comment has been minimized.

Show comment
Hide comment
@gitmate

gitmate bot Oct 5, 2018

GitMate.io thinks the contributor most likely able to help you is @GitMate[bot].

Possibly related issues are #390 (Fix alignment of image sequencer description), #345 (Display a flash message on removal of a step), #132 (fix CLI --options parameter and add example), and #378 (add a website icon to the website link).

gitmate bot commented Oct 5, 2018

GitMate.io thinks the contributor most likely able to help you is @GitMate[bot].

Possibly related issues are #390 (Fix alignment of image sequencer description), #345 (Display a flash message on removal of a step), #132 (fix CLI --options parameter and add example), and #378 (add a website icon to the website link).

@gitmate gitmate bot added the documentation label Oct 5, 2018

@dlarner3194

This comment has been minimized.

Show comment
Hide comment
@dlarner3194

dlarner3194 Oct 5, 2018

I can take this one

dlarner3194 commented Oct 5, 2018

I can take this one

@vanguard07

This comment has been minimized.

Show comment
Hide comment
@vanguard07

vanguard07 commented Oct 5, 2018

@publiclab/mentors Please review.

@dlarner3194

This comment has been minimized.

Show comment
Hide comment
@dlarner3194

dlarner3194 Oct 6, 2018

I submitted a PR for this issue here

dlarner3194 commented Oct 6, 2018

I submitted a PR for this issue here

@vanguard07

This comment has been minimized.

Show comment
Hide comment
@vanguard07

vanguard07 Oct 6, 2018

@dlarner3194 I made a mistake while writing the solution. Apologies for that. Could you update you PR accordingly? (Just replace the '#' with '.' in demo.css)

vanguard07 commented Oct 6, 2018

@dlarner3194 I made a mistake while writing the solution. Apologies for that. Could you update you PR accordingly? (Just replace the '#' with '.' in demo.css)

@tech4GT

This comment has been minimized.

Show comment
Hide comment
@tech4GT

tech4GT Oct 6, 2018

Member

Hi @vanguard07 @dlarner3194 Can you please elaborate on this issue with a screenshot?

Member

tech4GT commented Oct 6, 2018

Hi @vanguard07 @dlarner3194 Can you please elaborate on this issue with a screenshot?

@vanguard07

This comment has been minimized.

Show comment
Hide comment
@vanguard07

vanguard07 commented Oct 6, 2018

@tech4GT
Before:
screenshot 88
After:
screenshot 89

@tech4GT

This comment has been minimized.

Show comment
Hide comment
@tech4GT

tech4GT Oct 6, 2018

Member

hmm, I guess we can go ahead with this, my one concern is how it will react to smaller and larger screen sizes, did you try that?

Member

tech4GT commented Oct 6, 2018

hmm, I guess we can go ahead with this, my one concern is how it will react to smaller and larger screen sizes, did you try that?

@vanguard07

This comment has been minimized.

Show comment
Hide comment
@vanguard07

vanguard07 Oct 6, 2018

@tech4GT Yes I tried that. It looks good to me.
Before:
screenshot 90
After:
screenshot 91

vanguard07 commented Oct 6, 2018

@tech4GT Yes I tried that. It looks good to me.
Before:
screenshot 90
After:
screenshot 91

@tech4GT

This comment has been minimized.

Show comment
Hide comment
@tech4GT

tech4GT Oct 6, 2018

Member

Awesome!! You can go ahead and work on this one then, this looks good to me. Thanks!

Member

tech4GT commented Oct 6, 2018

Awesome!! You can go ahead and work on this one then, this looks good to me. Thanks!

karthikhegde05 pushed a commit to karthikhegde05/image-sequencer that referenced this issue Oct 7, 2018

@karthikhegde05

This comment has been minimized.

Show comment
Hide comment
@karthikhegde05

karthikhegde05 Oct 7, 2018

Hello sir, My name is Karthik Hegde. I wanted to ask if I could claim this issue and send a pull request. This would be my first contribution to opensource community.

karthikhegde05 commented Oct 7, 2018

Hello sir, My name is Karthik Hegde. I wanted to ask if I could claim this issue and send a pull request. This would be my first contribution to opensource community.

@dlarner3194

This comment has been minimized.

Show comment
Hide comment
@dlarner3194

dlarner3194 Oct 7, 2018

@dlarner3194 I made a mistake while writing the solution. Apologies for that. Could you update you PR accordingly? (Just replace the '#' with '.' in demo.css)

@vanguard07 Updated

dlarner3194 commented Oct 7, 2018

@dlarner3194 I made a mistake while writing the solution. Apologies for that. Could you update you PR accordingly? (Just replace the '#' with '.' in demo.css)

@vanguard07 Updated

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Oct 8, 2018

@karthikhedge05 - we'd love a contribution from you. This task is taken already but there are more at https://code.publiclab.org#r=all - please check it out! We can also help you find one if there's not one available. Thank you and welcome!

jywarren commented Oct 8, 2018

@karthikhedge05 - we'd love a contribution from you. This task is taken already but there are more at https://code.publiclab.org#r=all - please check it out! We can also help you find one if there's not one available. Thank you and welcome!

jywarren added a commit that referenced this issue Oct 8, 2018

Issue #392 Fixes alignment of message in Add step box (#393)
*  Fixes alignment of message in Add step box

* fixes css info id

* updates class selector in demo

* Spacing changes

jywarren added a commit that referenced this issue Oct 10, 2018

added gif feature (#360)
* added gif feature

* increased frame duration n changed gif btn name

* removed inline css

* improved ui

* #363 Add placeholder option to input (#370)

* Add placeholder option to input , change type of brightness input to number

 Changes to be committed:
	modified:   examples/lib/defaultHtmlStepUi.js
	modified:   src/modules/Brightness/info.json

* change 0% to 0 in brightness placeholder

* Add gamma module (#374)

* Add gamma module

* update description

* Add matrix math module (#358)

* Add matrix math module

* add info.json file

* correct format of module

* Add a constant factor input field

* clone the pixels array

* change default values

* add extra information on convolution module (#381)

* adds default values to input fields for all module steps ( fixes #382 ) (#384)

* added default values to input fields for all module steps

* merged

Signed-off-by: Ankit Singla <asingla590@gmail.com>

* Accept type images in input field #364 (#366)

* gif button name changed

* fixes #383 (#396)

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* fix (#387)

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* updated

* Issue #392 Fixes alignment of message in Add step box (#393)

*  Fixes alignment of message in Add step box

* fixes css info id

* updates class selector in demo

* Spacing changes

* correctly regulates the behaviour of all links (#397)

Signed-off-by: Ankit Singla <asingla590@gmail.com>

* enables Save button for an action if any of its input fields gain focus (#394)

* Updated index.html (#379)

* add histogram module (#354)

* add histogram module

Signed-off-by: tech4GT <varun.gupta1798@gmail.com>

* add option to drop gradient

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* fix bug

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

@tech4GT tech4GT removed the module label Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment