New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the Save Sequence button until one step is added #395

Open
tech4GT opened this Issue Oct 6, 2018 · 9 comments

Comments

Projects
None yet
5 participants
@tech4GT
Member

tech4GT commented Oct 6, 2018

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Issue

The save-sequence button in the UI should be disabled until some step is added in the sequence.

Here's where the save-sequence button is made:

<button class="btn btn-primary btn-lg" name="save-sequence" id="save-seq">Save Sequence</button>

We can make the button disable at the start and then enable it on first click of Add step button. We have to also disable the button if all the steps are removed.

@gitmate gitmate bot added the enhancement label Oct 6, 2018

@tech4GT

This comment has been minimized.

Show comment
Hide comment
@tech4GT

tech4GT Oct 6, 2018

Member

@jywarren Should we make this an FTO?

Member

tech4GT commented Oct 6, 2018

@jywarren Should we make this an FTO?

@gitmate

This comment has been minimized.

Show comment
Hide comment
@gitmate

gitmate bot Oct 6, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), #302 (Disable/dim the Save button until step inputs have been changed), #342 (Add a success prompt for saved sequence), #377 (Module save button is sometimes greyed out when needed), and #363 (add placeholder when brightness step applied).

gitmate bot commented Oct 6, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), #302 (Disable/dim the Save button until step inputs have been changed), #342 (Add a success prompt for saved sequence), #377 (Module save button is sometimes greyed out when needed), and #363 (add placeholder when brightness step applied).

1 similar comment
@gitmate

This comment has been minimized.

Show comment
Hide comment
@gitmate

gitmate bot Oct 6, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), #302 (Disable/dim the Save button until step inputs have been changed), #342 (Add a success prompt for saved sequence), #377 (Module save button is sometimes greyed out when needed), and #363 (add placeholder when brightness step applied).

gitmate bot commented Oct 6, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #303 (Disable/dim the Add step button until a module is selected), #302 (Disable/dim the Save button until step inputs have been changed), #342 (Add a success prompt for saved sequence), #377 (Module save button is sometimes greyed out when needed), and #363 (add placeholder when brightness step applied).

@jywarren

This comment has been minimized.

Show comment
Hide comment
@jywarren

jywarren Oct 9, 2018

jywarren commented Oct 9, 2018

@tech4GT

This comment has been minimized.

Show comment
Hide comment
@tech4GT

tech4GT Oct 11, 2018

Member

@Mridul97 Could you format this into a first timers issue, much thanks!!

Member

tech4GT commented Oct 11, 2018

@Mridul97 Could you format this into a first timers issue, much thanks!!

@Mridul97

This comment has been minimized.

Show comment
Hide comment
@Mridul97

Mridul97 Oct 11, 2018

Done! Should we make it a gci-candidate issue?

Mridul97 commented Oct 11, 2018

Done! Should we make it a gci-candidate issue?

@maciejmyslinski

This comment has been minimized.

Show comment
Hide comment
@maciejmyslinski

maciejmyslinski commented Oct 11, 2018

I'm on it.

@Divy123

This comment has been minimized.

Show comment
Hide comment
@Divy123

Divy123 Oct 18, 2018

Is this issue still open?

Divy123 commented Oct 18, 2018

Is this issue still open?

@tech4GT

This comment has been minimized.

Show comment
Hide comment
@tech4GT

tech4GT Oct 18, 2018

Member

@maciejmyslinski Are you still pursuing this one? If not @Divy123 can proceed with this. Thanks!

Member

tech4GT commented Oct 18, 2018

@maciejmyslinski Are you still pursuing this one? If not @Divy123 can proceed with this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment