New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align box in center in mobile view #484

Open
Paarmita opened this Issue Nov 20, 2018 · 17 comments

Comments

Projects
None yet
5 participants
@Paarmita
Member

Paarmita commented Nov 20, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem:

We want the Download PNG and View GIF buttons div in the center in the mobile view.

How to Solve?

You can add responsiveness in the div.

This line can be added below this one.

<div style="text-align:center;">

Instance Count 1

screenshot from 2018-11-20 13-11-29

@gitmate

This comment has been minimized.

gitmate bot commented Nov 20, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #355 (Adjust/Correct the position of Buttons in Mobile View), and #436 (Enhance gif view).

1 similar comment
@gitmate

This comment has been minimized.

gitmate bot commented Nov 20, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #355 (Adjust/Correct the position of Buttons in Mobile View), and #436 (Enhance gif view).

@gitmate gitmate bot added the question label Nov 20, 2018

@jywarren

This comment has been minimized.

jywarren commented Nov 20, 2018

@Rishabh570

This comment has been minimized.

Rishabh570 commented Nov 21, 2018

For anybody who would work on it, only removing this would made it sit in the center :)

@lwahlnayar

This comment has been minimized.

lwahlnayar commented Nov 22, 2018

Can I give it a go at this? I'm completely new to contributions =)

@Rishabh570

This comment has been minimized.

Rishabh570 commented Nov 22, 2018

@lwahlnayar Are you participating in GCI?

@lwahlnayar

This comment has been minimized.

lwahlnayar commented Nov 22, 2018

not really...

@Rishabh570

This comment has been minimized.

Rishabh570 commented Nov 22, 2018

Actually, this task is for GCI participants...I appreciate that you want to contribute, you can take a look at other open first-timer-only issues here: https://code.publiclab.org/

@lwahlnayar

This comment has been minimized.

lwahlnayar commented Nov 22, 2018

alright, thanks!

@JonathanXu1

This comment has been minimized.

JonathanXu1 commented Nov 26, 2018

Hey there, could I work on this for GCI? This task doesn't seem to be available on the dashboard but I'm also not aware if someone else is working on it...

@Rishabh570

This comment has been minimized.

Rishabh570 commented Nov 27, 2018

Yes, you can work on it as it's not claimed by anybody yet...I've created a draft for it, pinging @jywarren for reviewing it and publishing it :)

@JonathanXu1 JonathanXu1 referenced a pull request that will close this issue Nov 27, 2018

Open

Align box to center in mobile view #502

2 of 4 tasks complete
@JonathanXu1

This comment has been minimized.

JonathanXu1 commented Nov 27, 2018

@Rishabh570 great, I've centered the div in #502.

@jywarren

This comment has been minimized.

jywarren commented Nov 27, 2018

@JonathanXu1

This comment has been minimized.

JonathanXu1 commented Nov 28, 2018

Is there a link?

@Rishabh570

This comment has been minimized.

@JonathanXu1

This comment has been minimized.

JonathanXu1 commented Nov 28, 2018

Oh it seems like this is a beginner task. My bad.

@jywarren

This comment has been minimized.

jywarren commented Dec 2, 2018

Someone has claimed this in GCI and needs to post a pull request still. I requested more work, and we'll see if we hear back. Thanks everyone! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment