New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Save" to "Apply" on save button in add step UI #489

Closed
Rishabh570 opened this Issue Nov 22, 2018 · 14 comments

Comments

Projects
None yet
9 participants
@Rishabh570

Rishabh570 commented Nov 22, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem

Save button on a new step should have text on it saying: Apply instead of Save

Currently, it looks like,

screenshot from 2018-11-22 20-59-40

The Solution

This line in examples/lib/defaultHtmlStepUi.js would be updated in order to do the required changes.

- "<p><button class='btn btn-default btn-save' disabled = 'true' >Save</button><span> Press save to see changes</span></p>"
+ "<p><button class='btn btn-default btn-save' disabled = 'true' >Apply</button><span> Press save to see changes</span></p>"

It would look like this,

screenshot from 2018-11-22 21-05-26

Instance Count = 1

@welcome

This comment has been minimized.

welcome bot commented Nov 22, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@gitmate

This comment has been minimized.

gitmate bot commented Nov 22, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #466 (Add an "insert step" button on each step UI), #395 (Disable the Save Sequence button until one step is added), #302 (Disable/dim the Save button until step inputs have been changed), #348 (Improve Images step Ui), and #471 (Change Gif to GIF in 'View Gif' button.).

1 similar comment
@gitmate

This comment has been minimized.

gitmate bot commented Nov 22, 2018

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #466 (Add an "insert step" button on each step UI), #395 (Disable the Save Sequence button until one step is added), #302 (Disable/dim the Save button until step inputs have been changed), #348 (Improve Images step Ui), and #471 (Change Gif to GIF in 'View Gif' button.).

@rajcrk

This comment has been minimized.

rajcrk commented Nov 22, 2018

I would like to work on this issue.
Getting on it right now.

@HarshKhandeparkar

This comment has been minimized.

Member

HarshKhandeparkar commented Nov 22, 2018

@Rishabh570
I feel like the text besides it should also change to "press apply to see changes" or simply "press to see changes"

@jywarren

This comment has been minimized.

jywarren commented Nov 22, 2018

@Rishabh570

This comment has been minimized.

Rishabh570 commented Nov 22, 2018

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Nov 25, 2018

Is anyone working on this... I'd like to work on this issue

@Paarmita

This comment has been minimized.

Member

Paarmita commented Nov 25, 2018

@oorjitchowdhary I guess @rajcrk is working on this. You can see other first time issues.

@JonathanXu1

This comment has been minimized.

JonathanXu1 commented Nov 28, 2018

@rajcrk would you like help on this issue?

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Dec 4, 2018

@rajcrk are you still working on this? if not, @publiclab/mentors can I take this up?

@aashna27

This comment has been minimized.

aashna27 commented Dec 4, 2018

Since this is a first timer issue I would suggest you to move on with some other as you have already helped solve many other issues and let it be for someone new. :-)
@oorjitchowdhary

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Dec 5, 2018

@aashna27 Okay sure.. 😃

@tech4GT

This comment has been minimized.

Member

tech4GT commented Dec 8, 2018

I think this was solved, closing this now! Thanks everyone! 😄

@tech4GT tech4GT closed this Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment