New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command for installation is wrong in the readme. #514

Closed
Rishabh570 opened this Issue Dec 1, 2018 · 10 comments

Comments

Projects
None yet
4 participants
@Rishabh570

Rishabh570 commented Dec 1, 2018

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

The command for installing dependencies is wrong in the README.md file, below is the screenshot showing the line to be corrected...

screenshot from 2018-12-01 22-18-52

What did you expect to see that you didn't?

Instead of sudo npm setup it should be sudo npm run setup.

DIFF

- You can set up a local environment to test the UI with `sudo npm setup` followed by `npm start`
+ You can set up a local environment to test the UI with `sudo npm run setup` followed by `npm start` 

Please show us where to look

https://github.com/publiclab/image-sequencer/blob/main/README.md#unix-based-platforms

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@gitmate

This comment has been minimized.

gitmate bot commented Dec 1, 2018

GitMate.io thinks the contributor most likely able to help you is @oorjitchowdhary.

Possibly related issues are #101 (Clean up README), #338 (Display an installation message to user in the CLI), and #136 (Data model diagram in README).

1 similar comment
@gitmate

This comment has been minimized.

gitmate bot commented Dec 1, 2018

GitMate.io thinks the contributor most likely able to help you is @oorjitchowdhary.

Possibly related issues are #101 (Clean up README), #338 (Display an installation message to user in the CLI), and #136 (Data model diagram in README).

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Dec 1, 2018

Can i fix this?

@oorjitchowdhary oorjitchowdhary referenced this issue Dec 1, 2018

Closed

Update README.md #515

4 of 4 tasks complete
@Rishabh570

This comment has been minimized.

Rishabh570 commented Dec 1, 2018

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Dec 1, 2018

I kinda already made a pull request as it was a very small issue.. So should I close it to welcome a newcomer or let it be as is... 😢

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Dec 1, 2018

Ok I closed it down... Any newcomer may solve this. 😄

@jywarren

This comment has been minimized.

jywarren commented Dec 2, 2018

@momomen momomen referenced this issue Dec 4, 2018

Merged

Update README.md #525

2 of 2 tasks complete
@lwahlnayar

This comment has been minimized.

lwahlnayar commented Dec 5, 2018

Newcomer here. Has this issue already been taken care of, or can I go for it? Already made a pull request =)

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Dec 5, 2018

Wait a min.. I think @momomen solved it

@oorjitchowdhary

This comment has been minimized.

oorjitchowdhary commented Dec 5, 2018

@lwahlnayar You can try other first-timers-only or fto-candidate issues

@jywarren jywarren closed this in #525 Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment