Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step selector too narrow on mobile view #894

Open
Divy123 opened this issue Mar 19, 2019 · 28 comments

Comments

Projects
None yet
4 participants
@Divy123
Copy link

commented Mar 19, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

To Do: Make the step selector dropdown and add step button responsive.

To Fix

Screenshot_20190327-153954__01__01__01

You can have a look here for reference.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file examples/index.html in image-sequencer repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

Diff yet to be added.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

If a newcomer wants to solve an issue but cannot find one, they can get their name added to the list in #842

@Divy123

This comment has been minimized.

Copy link
Author

commented Mar 19, 2019

Thanks @HarshKhandeparkar

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

This issue is reserved for @An0u

@An0u An0u referenced a pull request that will close this issue Mar 21, 2019

Open

Update selectize.default.css #909

4 of 4 tasks complete
@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@Divy123 @harshithpabbati @aashna27 can this issue be solved by using bootstrap flex grid? The step selector can be given a class of .col-sm-12 .col-md-8 and the add step btn .col-sm-12 .col-md-4. Is this possible? Also changing selectize dist file directly isn't advisable. Also selectize is actually included through node modules, so no question about editing dist.

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

I guess we can do it.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@aashna27 what are your views on this?

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

I guess we can do it.

So shall we edit the issue?

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@HarshKhandeparkar I just tried it now but we need to even change the width of the option so we have to change in it's own css.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

I don't think we need to change the width. Did you try the col classes?

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Yeah I tried it.

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

xs
See this is what it's happening even if I use col-xs.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Do you have a screenshot?

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

It is happening because you are using col-xs. Try adding only .col-sm-12 class.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Please note that the columns have to be eirect children of a .row

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Yeah they are in that row div.

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Oh okay we want them in different lines right???

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

<div class="row">
  <div class="col-sm-12">
    <div>
       <!-- step selector markup -->
    </div>
  </div>
  <div class="col-sm-12">
    <div>
       <!-- add step btn markup -->
    </div>
  </div>
</div>
@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@HarshKhandeparkar i did the same thing

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

How is it not working then? It should work...

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

ch

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

It's because of the custom width of the selectize.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

The add step btn should have full sized....

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

May be even that have a particular width

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

It shouldn't...

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Try giving it a style width=100%

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

In demo.css it is having max-width:500px; thats the reason.

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Oh. Remove that and try...

@aashna27

This comment has been minimized.

Copy link

commented Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.