From b356b6c0a403e48ef4f8ad53f486a23afb30e879 Mon Sep 17 00:00:00 2001 From: Firela Date: Tue, 27 Aug 2019 23:35:49 +0530 Subject: [PATCH 1/2] Update pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 87c6d99c0b..b192bed8b3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,16 +1,16 @@ -Fixes #0000 (<=== Replace `0000` with the Issue Number) +Fixes #0000 (<=== Replace `0000` with the Issue Number) Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks! -* [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `npm test` -* [ ] code is in uniquely-named feature branch and has no merge conflicts -* [ ] PR is descriptively titled -* [ ] ask `@publiclab/is-reviewers` for help, in a comment below - -> We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first! +- [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `npm test` +- [ ] code is in uniquely-named feature branch and has no merge conflicts +- [ ] PR is descriptively titled +- [ ] ask `@publiclab/is-reviewers` for help, in a comment below +- [ ] Insert-step functionality is working correct as expected. + > We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first! If tests do fail, click on the red `X` to learn why by reading the logs. Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software - +Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks! From c6d306ccc26b00dbfb8bee6c228f2a24af29e3d8 Mon Sep 17 00:00:00 2001 From: Firela Date: Tue, 27 Aug 2019 23:39:55 +0530 Subject: [PATCH 2/2] Update Pull_Request.md --- .github/PULL_REQUEST_TEMPLATE.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b192bed8b3..2caac10946 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,13 +1,13 @@ -Fixes #0000 (<=== Replace `0000` with the Issue Number) +Fixes #0000 (<=== Replace `0000` with the Issue Number) Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks! -- [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `npm test` -- [ ] code is in uniquely-named feature branch and has no merge conflicts -- [ ] PR is descriptively titled -- [ ] ask `@publiclab/is-reviewers` for help, in a comment below -- [ ] Insert-step functionality is working correct as expected. - > We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first! +* [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `npm test` +* [ ] code is in uniquely-named feature branch and has no merge conflicts +* [ ] PR is descriptively titled +* [ ] ask `@publiclab/is-reviewers` for help, in a comment below +* [ ] Insert-step functionality is working correct as expected. +> We're happy to help you get this ready -- don't be afraid to ask for help, and **don't be discouraged** if your tests fail at first! If tests do fail, click on the red `X` to learn why by reading the logs.