Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added x and y input for custom resize #571

Open
wants to merge 1 commit into
base: main
from

Conversation

Projects
None yet
4 participants
@VibhorCodecianGupta
Copy link

commented Dec 30, 2018

Fixes #464

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in a uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome

This comment has been minimized.

Copy link

commented Dec 30, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@VibhorCodecianGupta

This comment has been minimized.

Copy link
Author

commented Dec 30, 2018

screen shot 2018-12-31 at 12 09 31 am

This is how the UI looks, and the resizes work well. However, we need a more foolproof method to let the user choose between custom and to scale resize. For now, I have placed a flag which checks whether the custom height/width has the default 125%. If they do, it assumes the user made changes according to to-scale resize, and if they don't , it is assumed the user changed the custom parameters. The problem occurs when the user has resized according to custom methods, but wants to again resize to-scale. Now because to-scale has 125% and the custom values are already changed, it wont read the changes made to to-scale parameters. Perhaps a checkbox could work fine? UI changes will have to be made.

@publiclab/reviewers
@tech4GT

@jywarren

This comment has been minimized.

Copy link

commented Jan 3, 2019

@VibhorCodecianGupta

This comment has been minimized.

Copy link
Author

commented Jan 3, 2019

@jywarren oh yes, that's a good idea. I'll try writing the code and push it by today.

@jywarren

This comment has been minimized.

Copy link

commented Mar 4, 2019

If you get to resolving this, please don't bother adding dist files; we will start to test not requiring them in PRs, and then it won't go out of sync, ok? Thanks!

@harshithpabbati

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Was this done ???

@HarshKhandeparkar

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Yes. Not merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.