Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Added x and y input for custom resize #571
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
If tests do fail, click on the red
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
This is how the UI looks, and the resizes work well. However, we need a more foolproof method to let the user choose between custom and to scale resize. For now, I have placed a flag which checks whether the custom height/width has the default
ah i see... what if we have a checkbox that says "preserve proportions" which then links the two - so a change to one affects the other -- but if it's not checked, the two can be changed and don't affect one another?…
On Sun, Dec 30, 2018 at 1:48 PM Vibhor Gupta ***@***.***> wrote: [image: screen shot 2018-12-31 at 12 09 31 am] <https://user-images.githubusercontent.com/29275810/50550186-05496c80-0c91-11e9-99b1-13f9858a7f00.png> This is how the UI looks, and the resizes work well. However, we need a more foolproof method to let the user choose between custom and to scale resize. For now, I have placed a flag which checks whether the custom height/width has the default 125%. If they do, it assumes the user made changes according to to-scale resize, and if they don't , it is assumed the user changed the custom parameters. The problem occurs when the user has resized according to custom methods, but wants to again resize to-scale. Now because to-scale has 125% and the custom values are already changed, it wont read the changes made to to-scale parameters. Perhaps a checkbox could work fine? UI changes will have to be made. @publiclab/reviewers @tech4GT <https://github.com/tech4GT> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#571 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ3JWMnv5KpYrayK8eMR99QPpMA0Wks5u-QpygaJpZM4ZlCIQ> .