Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseCornerCoordinateInputs bug fix #608

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
3 participants
@VibhorCodecianGupta
Copy link

commented Jan 5, 2019

Fixes #606

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@VibhorCodecianGupta

This comment has been minimized.

Copy link
Author

commented Jan 5, 2019

@publiclab/reviewers please review :)

@Divy123

Divy123 approved these changes Jan 5, 2019

Copy link

left a comment

Nice @VibhorCodecianGupta . @jywarren I think it can be merged now.

@jywarren

This comment has been minimized.

Copy link

commented Jan 5, 2019

Oops can you rebuild and rebase? Thanks!!

@ghost ghost assigned jywarren Jan 6, 2019

@ghost ghost added the in-progress label Jan 6, 2019

@jywarren jywarren referenced this pull request Jan 6, 2019

Merged

Fixed Save Button #562

4 of 4 tasks complete

@jywarren jywarren force-pushed the VibhorCodecianGupta:err branch from e334b9f to 4f856c2 Jan 6, 2019

@jywarren

This comment has been minimized.

Copy link

commented Jan 6, 2019

Rebased and rebuilt. Hope this works!

@jywarren jywarren merged commit 1a98247 into publiclab:main Jan 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jywarren

This comment has been minimized.

Copy link

commented Jan 6, 2019

Awesome!!!

@ghost ghost removed the in-progress label Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.